Fix URL and envs #11
Open
Fix URL and envs #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,13 +21,13 @@ | |||
| # Initialize FastMCP server | |||
| mcp = FastMCP("mcp-memgraph") | |||
|
|
|||
| MEMGRAPH_URI = "bolt://localhost:7687" | |||
| MEMGRAPH_URL = "bolt://localhost:7687" | |||
There was a problem hiding this comment.
Note for future selves + I guess product feedback.
We have MEMGRAPH_BOLT_PORT env in Memgraph, but there is no MEMGRAPH_BOLT_HOST. Ideally, there would be both, and then URI would be MEMGRAPH_BOLT_HOST:MEMGRAPH_BOLT_PORT and URL bolt://MEMGRAPH_BOLT_HOST:MEMGRAPH_BOLT_PORT, I think.
| @@ -15,7 +15,7 @@ | |||
| @pytest.fixture(scope="module") | |||
| def memgraph_connection(): | |||
| """Setup Memgraph connection fixture.""" | |||
| uri = os.getenv("MEMGRAPH_URI", "bolt://localhost:7687") | |||
| uri = os.getenv("MEMGRAPH_URL", "bolt://localhost:7687") | |||
There was a problem hiding this comment.
Suggestion: update 'uri' variable name as well, to avoid confusion.
katarinasupe
approved these changes
May 26, 2025
|
Additional comment: @antejavor please check the related issue and if you fixed all I was referring to - example in README for memgraph toolkit. [EDIT] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce enviroment variables and fix URL