Skip to content

Add support for routing policy enabled_reads_on_main #2907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Apr 28, 2025
Merged

Add support for routing policy enabled_reads_on_main #2907

merged 22 commits into from
Apr 28, 2025

Conversation

as51340
Copy link
Contributor

@as51340 as51340 commented Apr 16, 2025 •
edited
Loading

Adds runtime configuration option for reading from main. The policy is persisted through Raft logs so that all coordinators see the same value without the need of enabling the policy on all coordinators. New queries are added: SET COORDINATOR SETTING and SHOW COORDINATOR SETTINGS.

@as51340 as51340 added CI -build=coverage -test=core Run coverage build and core tests on push CI -build=debug -test=core Run debug build and core tests on push CI -build=release -test=e2e Run release build and e2e tests on push labels Apr 16, 2025
@as51340 as51340 self-assigned this Apr 16, 2025
@as51340 as51340 mentioned this pull request Apr 16, 2025
Closed
@as51340 as51340 changed the title Reroute run-time flag enabled_reads_on_main to raft Add support for routing policy enabled_reads_on_main Apr 17, 2025
@as51340 as51340 requested a review from andrejtonev April 17, 2025 12:35
@as51340 as51340 added this to the mg-v3.3.0 milestone Apr 17, 2025
@as51340
Copy link
Contributor Author

as51340 commented Apr 17, 2025 •
edited
Loading

Tracking

Standard development

CI Testing Labels

  • Select the appropriate CI test labels (CI -build=build-name -test=test-suite)

Documentation checklist

  • Add the documentation label
  • Add the bug / feature label
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Users can now configure whether reading is enabled from the main instance in HA cluster when bolt+routing protocol is used. Configuring is done using the SET COORDINATOR SETTING query. Before this change, reading was only allowed from replicas and this is still the default behaviour. The current configuration value can be obtained using SHOW COORDINATOR SETTINGS query. #2907
  • Documentation PR link
    • Is back linked to this development PR
  • [ Tag someone from docs team ] @matea16

@as51340 as51340 marked this pull request as ready for review April 17, 2025 12:36
@as51340 as51340 added feature feature Docs needed Docs needed labels Apr 17, 2025
@as51340 as51340 force-pushed the ft-enable-reads-on-main branch from 3c225a6 to c0b0523 Compare April 22, 2025 06:12
andrejtonev
andrejtonev reviewed Apr 22, 2025
View reviewed changes
@as51340 as51340 requested a review from andrejtonev April 23, 2025 20:52
@as51340 as51340 force-pushed the ft-enable-reads-on-main branch from c20e053 to 85f8e2d Compare April 28, 2025 06:09
andrejtonev
andrejtonev approved these changes Apr 28, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@as51340 as51340 enabled auto-merge April 28, 2025 18:05
@as51340 as51340 added this pull request to the merge queue Apr 28, 2025
Merged via the queue into master with commit 81ea43f Apr 28, 2025
17 checks passed
@as51340 as51340 deleted the ft-enable-reads-on-main branch April 28, 2025 19:11
@as51340 as51340 linked an issue Apr 29, 2025 that may be closed by this pull request
Implement reading from the MAIN instance under bolt+routing #2895
Closed
@as51340 as51340 mentioned this pull request Apr 29, 2025
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrejtonev andrejtonev andrejtonev approved these changes

Assignees

@as51340 as51340

Labels
Capability - high-availability CI -build=coverage -test=core Run coverage build and core tests on push CI -build=debug -test=core Run debug build and core tests on push CI -build=release -test=e2e Run release build and e2e tests on push Docs needed Docs needed feature feature
Projects
None yet
Milestone
mg-v3.3.0
Development

Successfully merging this pull request may close these issues.

Implement reading from the MAIN instance under bolt+routing
2 participants
@as51340 @andrejtonev