[WC-3283]: Fix custom pagination by samuelreichert · Pull Request #2116 · mendix/web-widgets

samuelreichert · 2026-02-26T13:21:37Z

Pull request type

New feature (non-breaking change which adds functionality)

Description

Adding the ability to show total count even when using virtual scrolling

packages/pluggableWidgets/datagrid-web/src/features/pagination/pagination.config.ts

iobuhov

LGTM

packages/shared/widget-plugin-grid/src/pagination/PageControl.service.ts

packages/shared/widget-plugin-grid/src/pagination/DynamicPagination.feature.ts

packages/pluggableWidgets/datagrid-web/src/model/containers/Datagrid.container.ts

packages/pluggableWidgets/gallery-web/src/model/containers/Gallery.container.ts

packages/shared/widget-plugin-grid/src/pagination/__tests__/DynamicPagination.feature.spec.ts

iobuhov

To debug infinite loop issue use trace from mobx pacakge and trace what causes dynamicPage to change. Then try to break the loop.
Overall looks good, but need rewrite in dynamic pagination feature and need rewire in container. Please review generated code before committing.

packages/shared/widget-plugin-grid/src/pagination/__tests__/DynamicPagination.feature.spec.ts

iobuhov

LGTM

...es/pluggableWidgets/datagrid-web/src/features/pagination/__tests__/pagination.config.spec.ts

packages/pluggableWidgets/datagrid-web/src/features/pagination/pagination.config.ts

packages/pluggableWidgets/gallery-web/src/model/configs/GalleryPagination.config.ts

…adedRows hook

…h loadedRows

…Size, and itemCount

…in getProperties

…eview dropzone

…tr writes on setProps

… with dynamicPage attribute

…inite loop

…overflow

…attribute

…uest totalCount

…ings

… in Studio Pro

…rovided values during setup

…irst XAS fetch

…tion behavior

…ateSetPageSizeAction

…ransform and fix lint warning

…n module and simplify tests Extracts loadedRowsAtom into the shared pagination module so consumer widgets no longer need to define it locally. Removes the redundant computed() wrapper in DynamicPagination.feature.spec.ts boxAtom helper, casting the observable.box directly with `as`. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

… and drop local definition Removes the local loadedRowsAtom wrapper (which was a redundant computed() around itemCount) now that the shared module exports it. Also cleans up the unused ComputedAtom and computed imports. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…ture injection The DynamicPaginationFeature constructor no longer takes a pageSize parameter, so the extra GY.paging.pageSize token in the injected() call caused a TS2554 build error. Also simplifies externalPageSize init to use nullish coalescing instead of a > 0 guard. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…eValue<number> IObservableValue<number> is a structural superset of ComputedAtom<number>, so the intermediate NumberAtomBox wrapper and boxAtom helper are unnecessary. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

config

scroll timer on cleanup

…geSize for deferred init

…namic page size

github-actions bot added the data-widgets label Feb 26, 2026

samuelreichert force-pushed the fix/WC-3283-custom-pagination branch 2 times, most recently from 853d08c to 2162f32 Compare February 27, 2026 12:35

samuelreichert marked this pull request as ready for review February 27, 2026 12:37

samuelreichert requested a review from a team as a code owner February 27, 2026 12:37

samuelreichert force-pushed the fix/WC-3283-custom-pagination branch from 2162f32 to 6dd4e1c Compare March 2, 2026 14:52

r0b1n reviewed Mar 4, 2026

View reviewed changes

packages/pluggableWidgets/datagrid-web/src/features/pagination/pagination.config.ts Outdated Show resolved Hide resolved

samuelreichert force-pushed the fix/WC-3283-custom-pagination branch from 6dd4e1c to 2097066 Compare March 4, 2026 14:56

github-actions bot added the shared label Mar 4, 2026

samuelreichert force-pushed the fix/WC-3283-custom-pagination branch 3 times, most recently from 25b265d to 092e537 Compare March 9, 2026 13:45

iobuhov previously approved these changes Mar 11, 2026

View reviewed changes

samuelreichert dismissed iobuhov’s stale review via 025ebe4 March 11, 2026 17:02

samuelreichert force-pushed the fix/WC-3283-custom-pagination branch from f083e01 to bb663b0 Compare March 12, 2026 14:11

iobuhov reviewed Mar 16, 2026

View reviewed changes

packages/pluggableWidgets/gallery-web/src/model/containers/Gallery.container.ts Outdated Show resolved Hide resolved

iobuhov reviewed Mar 16, 2026

View reviewed changes

packages/shared/widget-plugin-grid/src/pagination/__tests__/DynamicPagination.feature.spec.ts Show resolved Hide resolved

iobuhov requested changes Mar 16, 2026

View reviewed changes

iobuhov reviewed Mar 16, 2026

View reviewed changes

packages/shared/widget-plugin-grid/src/pagination/__tests__/DynamicPagination.feature.spec.ts Outdated Show resolved Hide resolved

iobuhov previously approved these changes Mar 17, 2026

View reviewed changes

samuelreichert force-pushed the fix/WC-3283-custom-pagination branch from 96298b6 to 9b98e19 Compare March 17, 2026 11:20

samuelreichert dismissed iobuhov’s stale review via 4940e3e March 17, 2026 12:47

samuelreichert force-pushed the fix/WC-3283-custom-pagination branch from 4940e3e to 09c4d7d Compare March 17, 2026 12:56

iobuhov requested changes Mar 18, 2026

View reviewed changes

samuelreichert requested review from iobuhov and r0b1n March 18, 2026 12:59

samuelreichert force-pushed the fix/WC-3283-custom-pagination branch from 5ee963a to 135c797 Compare March 18, 2026 13:07

samuelreichert added 2 commits March 18, 2026 14:09

feat(widget-plugin-grid): sync dynamic pagination attrs and expose lo…

78775eb

…adedRows hook

feat(datagrid-web): expose and sync pagination attrs across modes wit…

c6b9e20

…h loadedRows

samuelreichert and others added 29 commits March 18, 2026 14:09

feat(gallery-web): enhance pagination bindings with currentPage, page…

9e92ca3

…Size, and itemCount

fix(gallery-web): add clearSelectionButtonLabel to hidden properties …

401cf62

…in getProperties

fix(datagrid-web): move custom pagination to footer and add editor pr…

680a544

…eview dropzone

fix(widget-plugin-grid): prevent outbound autoruns from clobbering at…

54df9f5

…tr writes on setProps

fix(widget-plugin-grid): prevent infinite load loop in virtual scroll…

062429c

… with dynamicPage attribute

test(widget-plugin-grid): add regression tests for virtual scroll inf…

b36cdb4

…inite loop

fix(datagrid-web): only clamp grid body height when content does not …

c7c36f7

…overflow

fix(widget-plugin-grid): skip writing sentinel -1 to totalCountValue …

292821d

…attribute

fix(gallery-web): enable dynamic page sync for virtual scroll and req…

e5036da

…uest totalCount

feat(gallery-web): add loadedRowsValue attribute for loaded rows count

05481c0

fix(gallery-web): simplify property hiding for custom pagination sett…

eaf401c

…ings

chore(gallery-web): document fix for pagination properties visibility…

4b97d5f

… in Studio Pro

fix(widget-plugin-grid): ensure immediate application of externally-p…

6a8f64a

…rovided values during setup

fix(widget-plugin-grid): apply external pageSize/currentPage before f…

6e4cd18

…irst XAS fetch

fix(widget-plugin-grid): guard limit-based dynamic page init

dee064b

test(datagrid-web): update ColumnSelector unit tests for latest selec…

f42b838

…tion behavior

fix(widget-plugin-grid): rename unused config param to _config in cre…

1272272

…ateSetPageSizeAction

fix(widget-plugin-grid): add explicit TypeScript parser to SWC jest t…

1f700f9

…ransform and fix lint warning

test(datagrid-web): fix column selector click on e2e tests

9a434a9

refactor(data-widgets): extract resolveInitPageSize into pagination

d6a0429

config

fix(datagrid-web): prevent negative height lock and clear infinite

1012e74

scroll timer on cleanup

fix(widget-plugin-grid): skip setLimit if limit is unchanged

692365a

refactor(data-widgets): simplify resolveInitPageSize to use dynamicPa…

9ac8c77

…geSize for deferred init

fix(datagrid-web): recompute virtual scroll height on page size change

2e5f6ed

docs(data-widgets): document why resolveInitPageSize returns 0 for dy…

b953a32

…namic page size

samuelreichert force-pushed the fix/WC-3283-custom-pagination branch from 135c797 to b953a32 Compare March 18, 2026 13:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WC-3283]: Fix custom pagination#2116

[WC-3283]: Fix custom pagination#2116
samuelreichert wants to merge 32 commits intomainfrom
fix/WC-3283-custom-pagination

samuelreichert commented Feb 26, 2026 •

edited

Loading

Uh oh!

Uh oh!

iobuhov left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iobuhov left a comment

Uh oh!

Uh oh!

iobuhov left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

samuelreichert commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request type

Description

Uh oh!

Uh oh!

iobuhov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iobuhov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

iobuhov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

samuelreichert commented Feb 26, 2026 •

edited

Loading