Extract typings-generator into separate package#168
Open
iobuhov wants to merge 4 commits intomendix:masterfrom
Open
Extract typings-generator into separate package#168iobuhov wants to merge 4 commits intomendix:masterfrom
iobuhov wants to merge 4 commits intomendix:masterfrom
Conversation
…tor package Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
| let content: WidgetXml = {}; | ||
| if (xml) { | ||
| parseString(xml, {}, (err: Error, result: any) => { | ||
| parseString(xml, {}, (err: Error | null, result: any) => { |
Contributor
There was a problem hiding this comment.
Hello Ilia 👋 Why do we need the null here?
Contributor
Author
There was a problem hiding this comment.
IDK, probably just to avoid ts error.
iobuhov
force-pushed
the
extract-widget-typings-generator
branch
from
ccced1c to
ee3d221
Compare
LEGIO-SEXTA-FERRATA
requested changes
Mar 11, 2026
Contributor
LEGIO-SEXTA-FERRATA
left a comment
LEGIO-SEXTA-FERRATA
left a comment
There was a problem hiding this comment.
The generation tests are failing. The workspace:* seems to be not valid for the typings-generator dependency.
Contributor
Author
Yes, I forgot about this, working on that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts the typings-generator module into a new standalone package
@mendix/widget-typings-generatorfor better modularity and maintainability.All tests passing (40 in widget-typings-generator, 17 in pluggable-widgets-tools). Git history preserved with file renames.