PML-229 - Data re-uploading documentation page#152
PML-229 - Data re-uploading documentation page#152philippeschoeb wants to merge 1 commit intomerlinquantum:PML-211-doc-refactofrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e6766229e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Code Access and Documentation | ||
| ============================= | ||
|
|
||
| **GitHub Repository**: `merlin/reproductions/data_reuploading <https://github.com/merlinquantum/merlin/tree/main/reproductions/data_reuploading>`_ |
There was a problem hiding this comment.
Point repository link at an existing path
The new page’s “GitHub Repository” URL points to .../tree/main/reproductions/data_reuploading, but this commit does not add a reproductions/data_reuploading directory anywhere in the repo, so users following the link from the docs will hit a missing path instead of the referenced implementation. Update this link to the actual location of the reproduction assets (or add that folder in the same change) so the code-access section works.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@philippeschoeb, I believe the correct link is https://github.com/merlinquantum/reproduced_papers/tree/main/papers/data_reuploading
You can also use the gallery cards to link the repo (a bit like the qssl.rst or the qcnn_data_classification, maybe not merged yet)
CassNot
left a comment
There was a problem hiding this comment.
The GitHub link repo is wrong (can be fixed or fixed with a gallery card as well)
| Code Access and Documentation | ||
| ============================= | ||
|
|
||
| **GitHub Repository**: `merlin/reproductions/data_reuploading <https://github.com/merlinquantum/merlin/tree/main/reproductions/data_reuploading>`_ |
There was a problem hiding this comment.
@philippeschoeb, I believe the correct link is https://github.com/merlinquantum/reproduced_papers/tree/main/papers/data_reuploading
You can also use the gallery cards to link the repo (a bit like the qssl.rst or the qcnn_data_classification, maybe not merged yet)
Summary
Addition of the data re-uploading reproduction page to the MerLin doc
Related Issue
Type of change
Proposed changes
How to test / How to run
Screenshots / Logs (optional)
Performance considerations (optional)
Documentation
Checklist