Skip to content

PML-229 - Data re-uploading documentation page#152

Open
philippeschoeb wants to merge 1 commit intomerlinquantum:PML-211-doc-refactofrom
philippeschoeb:pml-211-data-reuploading
Open

PML-229 - Data re-uploading documentation page#152
philippeschoeb wants to merge 1 commit intomerlinquantum:PML-211-doc-refactofrom
philippeschoeb:pml-211-data-reuploading

Conversation

@philippeschoeb
Copy link
Contributor

Summary

Addition of the data re-uploading reproduction page to the MerLin doc

Related Issue

Type of change

  • Bug fix
  • New feature
  • Documentation update
  • Refactor / Cleanup
  • Performance improvement
  • CI / Build / Tooling
  • Breaking change (requires migration notes)

Proposed changes

How to test / How to run

  1. Command lines
Block of code

Screenshots / Logs (optional)

Performance considerations (optional)

Documentation

  • User docs updated (Sphinx)
  • Examples / notebooks updated
  • Docstrings updated

Checklist

  • PR title includes Jira issue key (e.g., PML-126)
  • "Related Jira ticket" section includes the Jira issue key (no URL)
  • Code formatted (ruff format)
  • Lint passes (ruff)
  • Static typing passes (mypy) if applicable
  • Unit tests added/updated (pytest)
  • Tests pass locally (pytest)
  • Tests pass on GPU (pytest)
  • Test coverage not decreased significantly
  • Docs build locally if affected (sphinx)
  • Dependencies updated (if needed) and pinned appropriately
  • PR description explains what changed and how to validate it

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0e6766229e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Code Access and Documentation
=============================

**GitHub Repository**: `merlin/reproductions/data_reuploading <https://github.com/merlinquantum/merlin/tree/main/reproductions/data_reuploading>`_

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Point repository link at an existing path

The new page’s “GitHub Repository” URL points to .../tree/main/reproductions/data_reuploading, but this commit does not add a reproductions/data_reuploading directory anywhere in the repo, so users following the link from the docs will hit a missing path instead of the referenced implementation. Update this link to the actual location of the reproduction assets (or add that folder in the same change) so the code-access section works.

Useful? React with 👍 / 👎.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philippeschoeb, I believe the correct link is https://github.com/merlinquantum/reproduced_papers/tree/main/papers/data_reuploading
You can also use the gallery cards to link the repo (a bit like the qssl.rst or the qcnn_data_classification, maybe not merged yet)

Copy link
Contributor

@CassNot CassNot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GitHub link repo is wrong (can be fixed or fixed with a gallery card as well)

Code Access and Documentation
=============================

**GitHub Repository**: `merlin/reproductions/data_reuploading <https://github.com/merlinquantum/merlin/tree/main/reproductions/data_reuploading>`_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philippeschoeb, I believe the correct link is https://github.com/merlinquantum/reproduced_papers/tree/main/papers/data_reuploading
You can also use the gallery cards to link the repo (a bit like the qssl.rst or the qcnn_data_classification, maybe not merged yet)

@CassNot CassNot added this to the Doc refactoring milestone Mar 13, 2026
@CassNot CassNot self-assigned this Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants