PML-168 paper reproduction limitations of amplitude encoding on quantum classification#69
Open
LF-Vigneux wants to merge 39 commits intomerlinquantum:mainfrom
Conversation
…s are fitting with the number of output classes
…oding-on-Quantum-Classification' of https://github.com/LF-Vigneux/reproduced_papers into PML-168-Paper-reproduction-Limitations-of-Amplitude-Encoding-on-Quantum-Classification
CassNot
requested changes
Mar 12, 2026
Contributor
CassNot
left a comment
CassNot
left a comment
There was a problem hiding this comment.
Nice work !
2 things to change:
- small one: remove the "TODO" from the readme
- bigger one: change the defaults.json so it is applied to one of the first datasets and is faster
papers/AA_study/README.md
Outdated
| python implementation.py --paper AA_study --config configs/defaults.json --batch_size 50 | ||
| ``` | ||
|
|
||
| ## Project structure --> TODO |
Contributor
There was a problem hiding this comment.
I think the TODO part is not needed here
Contributor
There was a problem hiding this comment.
I am having a timeout on tests,
- I think the number of epochs could be reduced to 1 (the goal is just to have a config for an experiment that runs in less than 120 seconds, the results do not need to be super great)
- Otherwise, as most of the time required to run this experiment is used to download BAS (that is a bit dangerous because directly correlated with the quality of the internet connexion), maybe the defaults.json could be on one of the first datasets (trace distance + classification or only classification)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduction of the paper https://arxiv.org/pdf/2503.01545