Skip to content

Conversation

@disgruntled-penguin
Copy link

This PR fixes a small bug (AttributeError: 'list' object has no attribute 'value') that was preventing it from rendering. Explicitly stating components= fixed it.

@tpike3
Copy link
Member

tpike3 commented Jan 8, 2026

Thank @disgruntled-penguin, I need to look into why the tests are failing this is a likely a repo name change issue.

However, could you elaborate on the specific bugs and show examples of the failure. Please also provide your dependency list (e.g., what version of Mesa you are using)

Thank you again for your support of Mesa.

@disgruntled-penguin
Copy link
Author

hello @tpike3 no problem! this was the error message when app.py was run:
Screenshot 2026-01-08 at 11 22 09 PM
i was looking through issues and found the same error for another gis example as well, im guessing this is a problem for all gis examples (issue #281).
also, i think the test is failing for another bug i tried to fix, i commited it in the same PR (fix conways rendering) (this was my first pr and i messed it up apologies)
i can open a new PR for this so itd be cleaner, and id be happy to fix it for other gis examples as well if thats okay!
dependencies were mesa-geo~=0.9.0 mesa>=3.3 solara>=1.55 for this specific example i believe

@tpike3
Copy link
Member

tpike3 commented Jan 9, 2026

hello @tpike3 no problem! this was the error message when app.py was run: Screenshot 2026-01-08 at 11 22 09 PM i was looking through issues and found the same error for another gis example as well, im guessing this is a problem for all gis examples (issue #281). also, i think the test is failing for another bug i tried to fix, i commited it in the same PR (fix conways rendering) (this was my first pr and i messed it up apologies) i can open a new PR for this so itd be cleaner, and id be happy to fix it for other gis examples as well if thats okay! dependencies were mesa-geo~=0.9.0 mesa>=3.3 solara>=1.55 for this specific example i believe

Thanks @disgruntled-penguin, try using mesa <= 3.3 -- there is a known issue with mesa-geo that it needs to be pinned to Mesa < 3.3.

@wang-boyu
Copy link
Member

Thanks @disgruntled-penguin for the fix. Changing components to keyword argument would indeed fix the error. However I didn't merge this PR because there's another commit about the game of life model, that I'm unsure what it was about.

For all GIS models I have created a separated PR to use keyword argument for soalra viz components: #311

@EwoutH
Copy link
Member

EwoutH commented Jan 25, 2026

This might be a good argument why we should require keyword only arguments in more places in Mesa (see mesa/mesa#2972 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants