Feature/acr #82
Merged
Feature/acr #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
florianow
force-pushed
the
feature/acr
branch
from
550c4b5 to
5c18f89
Compare
florianow
force-pushed
the
feature/acr
branch
from
864b911 to
ebf8f89
Compare
feat: fixing tests feat: fixing tests feat: fixing tests
florianow
force-pushed
the
feature/acr
branch
from
ebf8f89 to
eabb71c
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new Azure Container Registry (ACR) building block module, providing production-grade container registry infrastructure with optional private networking, hub connectivity, and AKS integration. The module supports multiple deployment scenarios from public registries to private endpoints with VNet peering.
- Complete ACR building block implementation with backplane permissions
- Private endpoint networking with VNet peering to hub networks
- Comprehensive test coverage for multiple deployment scenarios
Reviewed Changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| modules/azure/container-registry/buildingblock/*.tf | Core ACR module with networking, private endpoints, and role assignments |
| modules/azure/container-registry/buildingblock/*.md | Application team documentation and technical README |
| modules/azure/container-registry/buildingblock/acr.tftest.hcl | Comprehensive test scenarios for different deployment patterns |
| modules/azure/container-registry/backplane/*.tf | Backplane permissions and service principal management |
| modules/AGENTS.md | Updated documentation reflecting ACR additions and Azure patterns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
florianow
force-pushed
the
feature/acr
branch
from
dced6ef to
2832702
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.