Remove gradient sync nonce and simplify replay handling by thebentern · Pull Request #10459 · meshtastic/firmware

thebentern · 2026-05-12T00:07:00Z

I'm willing to admit, the gradient sync was a good idea, but it was a mistake to add new nonces. We should just always split the telem and position sync post complete node sync. Tested and it's working great on iOS. I'll do some Android testing too.

Copilot

Pull request overview

This PR removes the “gradient sync” opt-in nonces and simplifies PhoneAPI’s initial sync by (a) always sending thin NodeInfo headers for peers and (b) draining cached satellite-DB data (positions/telemetry/environment/status) after config_complete_id, interleaved with live traffic in STATE_SEND_PACKETS.

Changes:

Removed gradient-sync nonce definitions and the clientWantsGradientSync() gate.
Replaced the four replay states with a ReplayPhase mini-state-machine that drains in STATE_SEND_PACKETS.
Updated Copilot instructions to describe the new default sync/replay flow.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
`src/mesh/PhoneAPI.h`	Removes gradient nonce constants and introduces `ReplayPhase` helpers for post-sync replay.
`src/mesh/PhoneAPI.cpp`	Moves satellite replay to trail `config_complete_id` and interleave with live traffic; adjusts replay packet shaping (broadcast-like).
`.github/copilot-instructions.md`	Documents the new default sync flow (thin NodeInfos + post-complete replay drain).

thebentern · 2026-05-12T00:12:57Z

@copilot apply changes based on the comments in this thread

Agent-Logs-Url: https://github.com/meshtastic/firmware/sessions/cfa93978-e2e0-4dc2-ba5f-b82b5b43cef8 Co-authored-by: thebentern <9000580+thebentern@users.noreply.github.com>

Copilot · 2026-05-12T00:21:45Z

@copilot apply changes based on the comments in this thread

Applied the requested review-thread fixes in 2a8e030: SPECIAL_NONCE_ONLY_CONFIG now skips post-complete replay, stale gradient-sync wording was removed from PhoneAPI comments, and the sync-flow docs were reworded to describe default flow plus explicit nonce exceptions.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

api.registry.nm1.platformio.org
- Triggering command: /home/REDACTED/.local/bin/pio /home/REDACTED/.local/bin/pio test -e native -f test_default (dns block)
- Triggering command: /home/REDACTED/.local/bin/pio /home/REDACTED/.local/bin/pio test -e native -f test_default -v (dns block)
- Triggering command: /home/REDACTED/.local/bin/pio /home/REDACTED/.local/bin/pio test -e native -f test_default --json-output gsign/gh-gpgsign-linux-x86_64 (dns block)
api.registry.platformio.org
- Triggering command: /home/REDACTED/.local/bin/pio /home/REDACTED/.local/bin/pio test -e native -f test_default (dns block)
- Triggering command: /home/REDACTED/.local/bin/pio /home/REDACTED/.local/bin/pio test -e native -f test_default -v (dns block)
- Triggering command: /home/REDACTED/.local/bin/pio /home/REDACTED/.local/bin/pio test -e native -f test_default --json-output gsign/gh-gpgsign-linux-x86_64 (dns block)
collector.platformio.org
- Triggering command: /home/REDACTED/.local/bin/pio /home/REDACTED/.local/bin/pio test -e native -f test_default (dns block)
- Triggering command: /home/REDACTED/.local/bin/pio /home/REDACTED/.local/bin/pio test -e native -f test_default -v (dns block)
- Triggering command: /home/REDACTED/.local/bin/pio /home/REDACTED/.local/bin/pio test -e native -f test_default --json-output gsign/gh-gpgsign-linux-x86_64 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Copilot

Pull request overview

Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.

 meshtastic_PositionLite TypeConversions::ConvertToPositionLite(meshtastic_Position position)
 {
    meshtastic_PositionLite lite = meshtastic_PositionLite_init_default;
    lite.latitude_i = position.latitude_i;
    lite.longitude_i = position.longitude_i;
    lite.altitude = position.altitude;
    lite.location_source = position.location_source;
    lite.time = position.time;
+    lite.precision_bits = position.precision_bits;


thebentern · 2026-05-12T02:07:33Z

@copilot apply changes based on the comments in this thread

Agent-Logs-Url: https://github.com/meshtastic/firmware/sessions/41572cbc-408e-499d-b59e-00f330b5789f Co-authored-by: thebentern <9000580+thebentern@users.noreply.github.com>

Copilot · 2026-05-12T02:14:30Z

@copilot apply changes based on the comments in this thread

Applied the review-thread follow-ups in a231370: ConvertToNodeInfo(..., position, ...) now copies position->precision_bits into bundled NodeInfo.position, and the temporary per-node LOG_INFO sync logging was removed from PhoneAPI.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

api.registry.nm1.platformio.org
- Triggering command: /home/REDACTED/.local/bin/pio /home/REDACTED/.local/bin/pio test -e native -f test_type_conversions (dns block)
api.registry.platformio.org
- Triggering command: /home/REDACTED/.local/bin/pio /home/REDACTED/.local/bin/pio test -e native -f test_type_conversions (dns block)
collector.platformio.org
- Triggering command: /home/REDACTED/.local/bin/pio /home/REDACTED/.local/bin/pio test -e native -f test_type_conversions (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Remove gradient sync nonce and simplify replay handling

0fceed1

thebentern requested a review from Copilot May 12, 2026 00:07

github-actions Bot added needs-review Needs human review enhancement New feature or request labels May 12, 2026

Copilot started reviewing on behalf of thebentern May 12, 2026 00:07 View session

Copilot AI reviewed May 12, 2026

View reviewed changes

Comment thread src/mesh/PhoneAPI.cpp Outdated

Comment thread src/mesh/PhoneAPI.h Outdated

Comment thread src/mesh/PhoneAPI.cpp Outdated

Comment thread src/mesh/PhoneAPI.cpp Outdated

Comment thread .github/copilot-instructions.md

Copilot started work on behalf of thebentern May 12, 2026 00:13 View session

Fix ONLY_CONFIG replay gating and stale gradient-sync comments

2a8e030

Agent-Logs-Url: https://github.com/meshtastic/firmware/sessions/cfa93978-e2e0-4dc2-ba5f-b82b5b43cef8 Co-authored-by: thebentern <9000580+thebentern@users.noreply.github.com>

Copilot finished work on behalf of thebentern May 12, 2026 00:22

thebentern added 3 commits May 11, 2026 19:30

Add transport mechanism to replay packets for client filtering

c2d2e61

Comments

9731f1a

Update protobuf definitions to include precision_bits in PositionLite

fb9259c

thebentern requested a review from Copilot May 12, 2026 02:01

Copilot started reviewing on behalf of thebentern May 12, 2026 02:02 View session

Copilot AI reviewed May 12, 2026

View reviewed changes

Copilot started work on behalf of thebentern May 12, 2026 02:07 View session

Propagate position precision_bits and remove verbose NodeInfo sync log

a231370

Agent-Logs-Url: https://github.com/meshtastic/firmware/sessions/41572cbc-408e-499d-b59e-00f330b5789f Co-authored-by: thebentern <9000580+thebentern@users.noreply.github.com>

Copilot finished work on behalf of thebentern May 12, 2026 02:15

thebentern merged commit f7548e7 into develop May 12, 2026
68 checks passed

thebentern deleted the remove-gradient-sync-nonce branch May 12, 2026 02:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove gradient sync nonce and simplify replay handling#10459

Remove gradient sync nonce and simplify replay handling#10459
thebentern merged 6 commits into
developfrom
remove-gradient-sync-nonce

thebentern commented May 12, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thebentern commented May 12, 2026

Uh oh!

Copilot AI commented May 12, 2026 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

thebentern commented May 12, 2026

Uh oh!

Copilot AI commented May 12, 2026 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

thebentern commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thebentern commented May 12, 2026

Uh oh!

Copilot AI commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

thebentern commented May 12, 2026

Uh oh!

Copilot AI commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

thebentern commented May 12, 2026 •

edited

Loading

Copilot AI commented May 12, 2026 •

edited

Loading

Copilot AI commented May 12, 2026 •

edited

Loading