Skip to content

[Variant] nomadstar meteor pro #6742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

CypressXt
Copy link
Contributor

Hello there 👋,

This PR includes all necessary additions to support a new variant for our NomadStar Meteor Pro.
Feedback and comments are always welcome and very appreciated ☺️ !

Copy link
Member

@caveman99 caveman99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately i can't update the tree to our latest master, you need to allow maintainer edits.

@CypressXt
Copy link
Contributor Author

Hey @caveman99, thanks a lot for the review and the feedback ☺️ !

I've now remove unnecessary dependencies from our variant.
The build now passes ✅ and we are conducting further testing on our hardware to confirm that everything is still working as expected.

I'll keep you posted 🖖

@CypressXt
Copy link
Contributor Author

Thanks a lot for the review @caveman99, we tested it on our hardware and everything works as expected. This PR can be merge whenever it's alright for you to do so ☺️

@CypressXt CypressXt marked this pull request as ready for review May 23, 2025 15:14
@caveman99
Copy link
Member

@CypressXt there's one thing that's missing. the HWID mapping in src/platform/nrf52/architecture.h

@CypressXt
Copy link
Contributor Author

@CypressXt there's one thing that's missing. the HWID mapping in src/platform/nrf52/architecture.h

Ah yes thanks ! Is there any specific schematic expected for this string or would something like this be acceptable:

...
#elif defined(NOMADSTAR_METEOR_PRO)
#define HW_VENDOR meshtastic_HardwareModel_NOMADSTAR_METEOR_PRO
#else
...

@caveman99
Copy link
Member

The define needs to match the protobuf constant, and the macro is something you set in platformio.ini to distinguish your hardware from the rest :-)

@caveman99
Copy link
Member

build_flags = ${nrf52840_base.build_flags} -Ivariants/rak4631_nomadstar_meteor_pro -D NOMADSTAR_METEOR_PRO

  /* NomadStar Meteor Pro https://nomadstar.ch/ */
    meshtastic_HardwareModel_NOMADSTAR_METEOR_PRO = 96,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants