-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Variant] nomadstar meteor pro #6742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[Variant] nomadstar meteor pro #6742
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately i can't update the tree to our latest master, you need to allow maintainer edits.
Hey @caveman99, thanks a lot for the review and the feedback I've now remove unnecessary dependencies from our variant. I'll keep you posted 🖖 |
Thanks a lot for the review @caveman99, we tested it on our hardware and everything works as expected. This PR can be merge whenever it's alright for you to do so |
@CypressXt there's one thing that's missing. the HWID mapping in src/platform/nrf52/architecture.h |
Ah yes thanks ! Is there any specific schematic expected for this string or would something like this be acceptable:
|
The define needs to match the protobuf constant, and the macro is something you set in platformio.ini to distinguish your hardware from the rest :-) |
|
Hello there 👋,
This PR includes all necessary additions to support a new variant for our NomadStar Meteor Pro.☺️ !
Feedback and comments are always welcome and very appreciated