Mute: Nodes #8088
Mute: Nodes #8088
Conversation
|
@garthvh Here's the one for nodes, should we revisit this in future. |
ford-jones
added
enhancement
|
@garthvh the |
| /* Tell the node to store UI data persistently. */ | ||
| meshtastic_DeviceUIConfig store_ui_config; | ||
| /* Set specified node-num to be ignored on the NodeDB on the device */ | ||
| uint32_t set_ignored_node; |
There was a problem hiding this comment.
If the protobufs have been updated, we shouldn't see the changes in here. Someone probably needs to do a protobuf merge from master or something ...
There was a problem hiding this comment.
Hey! Not sure I'm understanding correctly.
These protobuf additions (set_muted_node and remove_muted_node) were added by me and pertain to this pull request. This stuff here is the result of running regen-protos.sh.
Is that what you're referring to?
The protobuf changes are here: meshtastic/protobufs#779
There was a problem hiding this comment.
generally the protobuf changes are merged into the repo separately through an automated process, so individual patches shouldn't need to carry the changes...
There was a problem hiding this comment.
I hear ya, that's why I opened the proto PR. I'm just a little confused as this file we're discussing is one of the generated/meshtastic/*.pb.h. Should these not be checked in? Otherwise this wouldn't build or pass the CI.
Happy to jump in a call to get on the same page when you're next available 🙂
Sorry if I'm totally misunderstanding.
There was a problem hiding this comment.
New, you're right - since the protobuf was released they should be here, and so these changes would just magically disappear . But it's not, so the automation is not working.
|
@thebentern here's the PR we were chattin about on the phone today 🙂 |
|
@fifieldt let me know if this is looking better to you, I just resolved a conflict in the protobuf submodule's ref's. |
2 participants
Resolves #7943
Introduces mechanisms to mute message notifications received from certain nodes.
When a message is received from a muted node, the device's buzzer (if present) should not be activated. Drawing of any alert UI notification to the device's screen should also be blocked.
The exception to this is bell alerts (when activated), which should still sound the buzzer and display a notification.
It should be noted that this behaviour is distinctly different to ignoring a node - an action which blocks the message entirely. Muted messages can still be viewed in the messages menu of the device or client application, they are just delivered discreetly - similar to muting a channel.
Protobuf changes: meshtastic/protobufs#779
Python CLI Changes: meshtastic/python#822
Docs: meshtastic/meshtastic#2038
🤝 Attestations