- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.7k
Add build support for TenStar Esp32-C3 SuperMini #8434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add build support for TenStar Esp32-C3 SuperMini #8434
Conversation
049a53b    to
    7a5a2ab      
    Compare
  
    7a5a2ab    to
    18fc821      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally I can see what you're trying to do here - using the named pins for their described purpose rather than using the existing pinout. However, I've left some notes for you.
If you're going to raise a new variant, perhaps consider trying to match the ESP32S3 zero, which has an almost-identical-but-mirrored pinout, and could therefore share boards (with adjustment for buttons).
| #define GPS_TX_PIN (21) | ||
|  | ||
| // Button, active LOW | ||
| #define BUTTON_PIN (10) | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I traced the boot button through to pin 9 on my boards, and the very-difficult-to-read schematic on the Tenstar Robot store Aliexpress page also seems to indicate that it is linked to GPIO9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried PIN8 and PIN9 for button but in both cases the I2C got stuck: display, sensors, nothing communicates. So I moved to an other pin, in this case PIN10. Maybe I should change the comments: "Connect Button to this pin, active LOW"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment below. Io9 is a strapping pin, and also connected to a button, so using it for anything other than a user button doesn't make sense.
| // Button, active LOW | ||
| #define BUTTON_PIN (10) | ||
|  | ||
| // LoRa | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you expand on why you chose these pins?
For reference, the ones in the original super_mini were chosen because they matched the existing Heltec HT-CT62 internal pins, and were therefore known to be usable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, on the esp32c3 they're not fixed functions. I'm not sure why they've used them in this way.
I'd strongly suggest rethinking the use of io9 for anything other than the button that it is connected to.
| @kzsolt3141 have you tried the other pinout for the supermini? You said that it's not compatible, but if you try it you may find that it works. | 

Tried to build the esp32c3_super_mini platform for my ESP32C3-SuperMini. The defined pinout was not compatible with my version.
Added new variant, with the correct pinout.
Tested with my own ESP32C3-SuperMini, LLCC68 LoRa, SSD1306, works correctly.