Skip to content

Conversation

@Brandon-T
Copy link

@Brandon-T Brandon-T commented Oct 25, 2025

Fixed: #8409

image

🤝 Attestations

  • I have tested that my proposed changes behave as described.
  • I have tested that my proposed changes do not cause any obvious regressions on the following devices:
    • Heltec (Lora32) V3
    • LilyGo T-Deck
    • LilyGo T-Beam
    • RAK WisBlock 4631
    • Seeed Studio T-1000E tracker card
    • Other (please specify below)

@CLAassistant
Copy link

CLAassistant commented Oct 25, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@fifieldt fifieldt added the enhancement New feature or request label Oct 25, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest removing the ASCII artwork. It's cute when the OEM does it. It's annoying if it's everywhere.

@NomDeTom
Copy link
Contributor

This looks good, and it's good that you've tested it. Putting it in DIY as a separate variant is the right thing to do.

@fifieldt does this need to be private_hw or continue under the HWID for the xiao S3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Board]: XIAO Wio-SX1262 Header Board (NOT Kit)

4 participants