Skip to content

Better implementation of ExternalNotificationModule::stopNow #8492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 31, 2025
Merged

Better implementation of ExternalNotificationModule::stopNow #8492

merged 3 commits into from
Oct 31, 2025

Conversation

@Xaositek
Copy link
Contributor

@Xaositek Xaositek commented Oct 30, 2025 •
edited
Loading

  • Better implementation of ExternalNotificationModule::stopNow
  • Improved ExternalNotificationModule::stopNow with logging from runOne version
  • Fixed isRtttlPlaying checks so it works effectively

@Xaositek Xaositek requested a review from thebentern October 30, 2025 13:09
@Xaositek Xaositek self-assigned this Oct 30, 2025
@Xaositek Xaositek added bug Something isn't working baseui Issues directly related to BaseUI bugfix Pull request that fixes bugs labels Oct 30, 2025
@thebentern thebentern requested a review from Copilot October 30, 2025 13:12
Copilot AI reviewed Oct 30, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors duplicate code by extracting notification cleanup logic into a centralized stopNow() method. The change improves code maintainability by eliminating code duplication that existed in the runOnce() method.

  • Extracted inline notification cleanup code from runOnce() into the existing stopNow() method
  • Added detailed logging statements in stopNow() to track each cleanup step
  • Moved GPIO0 reset logic (for I2S/T-Deck compatibility) into stopNow() for centralized handling

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Xaositek Xaositek marked this pull request as ready for review October 30, 2025 13:34
@Xaositek Xaositek marked this pull request as draft October 30, 2025 14:06
@Xaositek Xaositek marked this pull request as ready for review October 30, 2025 14:57
@Xaositek
Copy link
Contributor Author

Tested on Meshenger (one of the original devices to show problems), NRF TXT, and HEL TXT.

@thebentern thebentern merged commit d00fda2 into master Oct 31, 2025
77 checks passed
@thebentern thebentern deleted the BetterImplementof_ExternalNotificationModule_stopNow branch October 31, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@thebentern thebentern Awaiting requested review from thebentern

Assignees

@Xaositek Xaositek

Labels

baseui Issues directly related to BaseUI bug Something isn't working bugfix Pull request that fixes bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Xaositek @thebentern