feat(mesh): add BLE advertisement protobuf enums#917
Open
Komzpa wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds protobuf enum values needed by the firmware BLE advertisement bearer scaffold:
Config.NetworkConfig.ProtocolFlags.BLE_ADVERTISEMENT_BROADCASTfor enabling BLE advertisement packet broadcasts.MeshPacket.TransportMechanism.TRANSPORT_BLE_ADVERTISEMENTso packets received through that bearer can be tagged distinctly.buf formatrejects inmeshtastic/mesh.proto, so this PR can pass the current format gate after touching that file.This supports meshtastic/firmware#10292; that firmware draft should stay draft until this schema lands and generated bindings are refreshed from the canonical protobufs submodule.
Validation
buf format --diff --exit-code --path meshtastic/config.proto --path meshtastic/mesh.proto .buf lint --path meshtastic/config.proto --path meshtastic/mesh.proto .buf lint .protoc -I. --include_imports --descriptor_set_out=/tmp/meshtastic-ble-adv.desc meshtastic/*.proto nanopb.protogit diff --check origin/master...HEADcodex review --base origin/masterChecklist before merging