-
Notifications
You must be signed in to change notification settings - Fork 302
Fix pytest test collection on default install #749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As is, with a default `poetry install`, a simple `poetry pytest run` will encouter import errors while reading the test files themselves -- which causes pytest to fatally error during test collection, meaning no tests are run.
|
As a test, I opened the PR into a gitpod workspace and did the following.
Got the following output from pytest: Workspace details:
I had a suggestion if there is interest. I am not sure if this is helpful or not, but I have found this useful in the past and it can reduce review time. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #749 +/- ##
=======================================
Coverage 60.14% 60.14%
=======================================
Files 24 24
Lines 4062 4062
=======================================
Hits 2443 2443
Misses 1619 1619
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
As discussed on Discord, I'll also create new pytest markers for analytics, powermon, and tunnel, and make them default-excluded (like the other ones with 'optional dependencies' like "two radios connected over USB" are). |
|
Sorry about the delay, this looks great. Thanks for the PR! |
As is, with a default
poetry install, a simplepoetry pytest runwill encouter import errors while reading the test files themselves -- which causes pytest to fatally error during test collection, meaning no tests are run.