Skip to content

Conversation

@Crank-Git
Copy link
Contributor

…from accepting empty or whitespace-only names. This is in relation to feature request meshtastic/firmware#6867.

Added test validation and when trying to set long, short, and ham names we get the following via the cli:

python -c "import sys; sys.argv = ['', '--set-ham', '   ']; from meshtastic.__main__ import main; main()"
ERROR: Ham ID cannot be empty or contain only whitespace characters

python -c "import sys; sys.argv = ['', '--set-owner', '   ']; from meshtastic.__main__ import main; main()"
ERROR: Long Name cannot be empty or contain only whitespace characters

python -c "import sys; sys.argv = ['', '--set-owner-short', '   ']; from meshtastic.__main__ import main; main()"
ERROR: Short Name cannot be empty or contain only whitespace characters

Please let me know if there is anything else that I should add or modify. I have no idea what I am doing with Android SDK/development, so I believe someone will need to add this validation so the app also gives an error/warning when trying to set these.

…from accepting empty or whitespace-only names. This is in relation to meshtastic#6867 firmware feature request meshtastic/firmware#6867
@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

Attention: Patch coverage is 65.71429% with 12 lines in your changes missing coverage. Please review.

Project coverage is 60.08%. Comparing base (622a435) to head (8a6ee5f).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
meshtastic/__main__.py 61.29% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #782      +/-   ##
==========================================
+ Coverage   59.60%   60.08%   +0.48%     
==========================================
  Files          24       24              
  Lines        4114     4149      +35     
==========================================
+ Hits         2452     2493      +41     
+ Misses       1662     1656       -6     
Flag Coverage Δ
unittests 60.08% <65.71%> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ianmcorvidae
Copy link
Contributor

Sorry for the delay on my getting back to this. Looks good, I'll merge it now, and probably push out a release soon as well.

@ianmcorvidae ianmcorvidae merged commit c55f1ef into meshtastic:master Jun 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants