[RFC] Tests: set DYLD_LIBRARY_PATH on Darwin #14430
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhancement of mesonbuild#11119
dcbaker
requested changes
Apr 1, 2025
There was a problem hiding this comment.
Reading the man page from darwin, it looks like this is correct, although I don't have a mac handy to test with, and I'm not sure if we have any tests that get run on Mac for this feature? It would be nice to verify that this is, in fact, working as we expect
Comment on lines
+1298
to
+1301
| if machine.is_darwin(): | ||
| t_env.prepend('DYLD_LIBRARY_PATH', list(ld_lib_path), ':') | ||
| else: | ||
| t_env.prepend('LD_LIBRARY_PATH', list(ld_lib_path), ':') |
There was a problem hiding this comment.
I'd have a slight preference for something like:
var = 'DYLD_LIBRARY_PATH' if machine.is_darwin() else 'LD_LIBRARY_PATH'
t_env.prepend(var, ...)since everything else is the same between the two paths.
dcbaker
added
the
OS:macos
|
Sorry, I'd missed this before. I'll look at the other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I can tell,
DYLD_LIBRARY_PATHhas precedence over rpath, just likeLD_LIBRARY_PATHhas on other Unices.Enhance #11119 to work on Darwin.