CI: remove hardcoded paths in cygwin workflow#15612
Open
jon-turney wants to merge 2 commits intomesonbuild:masterfrom
Open
CI: remove hardcoded paths in cygwin workflow#15612jon-turney wants to merge 2 commits intomesonbuild:masterfrom
jon-turney wants to merge 2 commits intomesonbuild:masterfrom
Conversation
cygwin-install-action adds cygwin's /usr/bin to PATH by default, so this isn't needed.
per the suggestion at [1], locate the pip cache dir programmatically, rather than hardcoding a (brittle) path. [1] mesonbuild#14425 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is kind of another attempt at the left-over bits of #14425, after we've delegated the choice of location for best performance to cygwin-install-action.
Also, per the suggestion in #14425 (comment), locate the pip cache dir programmatically, rather than hardcoding another (brittle) path.