Suggest using run_single_test.py when test is passed to run_project_tests.py --only#15625
Open
bonzini wants to merge 1 commit intomesonbuild:masterfrom
Open
Suggest using run_single_test.py when test is passed to run_project_tests.py --only#15625bonzini wants to merge 1 commit intomesonbuild:masterfrom
bonzini wants to merge 1 commit intomesonbuild:masterfrom
Conversation
Contributor
Author
|
@dcbaker alternatively, the error could point to |
Member
|
I would very much prefer that it points to single tests. The number of times that I wrote "failing" and had to wait for it to do all of the sanity checking before it finally said "that isn't a category" is infuriating. And, that honestly seems more like a bug that you could do |
Detect the case where a single test is being requested, and direct the user to run_single_test.py. This used to work until commit 7f2dd41 ("run_project_tests: Add choices to the --only argument"). Example: $ ./run_project_tests.py --only='framework' ... run_project_tests.py: error: argument --only: invalid argument 'framework' for --only; must be one of ... $ ./run_project_tests.py --only='framework/7 gnome' ... run_project_tests.py: error: argument --only: invalid argument 'framework/7 gnome' for --only; must be one of ... but then: $ ./run_project_tests.py --only='frameworks/7 gnome' ... run_project_tests.py: error: argument --only: use ./run_single_test.py 'test cases/frameworks/7 gnome' to run a single test Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
bonzini
force-pushed
the
project-tests-only-choices-revert
branch
from
f0ad0bd to
2fd847d
Compare
bonzini
changed the title
Contributor
Author
Well, it was in the help message hence my first instinct to revert. But yes, it's possible to print a better message via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 7f2dd41.Prior to commit 7f2dd41, it was possible to run a single test with./run_project_tests.sh --only='common/1 trivial'
while it is not possible afterwards.
Suggest a replacement, and remove the
category/namecase from the help message.