support parallel test execution #260
Conversation
|
I couldn't help myself and just added test lookup functionality (right click on test -> Go to Test). This leads to the source file that a test exe is built from. This only works for simple tests that are made up of one source file, but that should be the majority of tests. |
Jannik2099
force-pushed
the
parallel_tests
branch
from
1523925 to
b94ce5d
Compare
|
@Jannik2099 do you think this PR is ready to go? Sorry it's taken me a long time to get to it |
Jannik2099
force-pushed
the
parallel_tests
branch
3 times, most recently
from
d70915c to
ecdb6f2
Compare
|
Sorry for the delay, I managed to break my finger which made interfacing with a keyboard... difficult. I addressed all your points. |
|
I guess this slipped my mind when cutting the new release. Is there any way you could rebase on main, so I can get this for 1.28? |
Signed-off-by: Jannik Glückert <[email protected]>
Signed-off-by: Jannik Glückert <[email protected]>
Signed-off-by: Jannik Glückert <[email protected]>
Signed-off-by: Jannik Glückert <[email protected]>
this is required when targets exist twice, e.g. due to subprojects Signed-off-by: Jannik Glückert <[email protected]>
Signed-off-by: Jannik Glückert <[email protected]>
Jannik2099
force-pushed
the
parallel_tests
branch
from
ecdb6f2 to
504f766
Compare
|
No worries, I rebased & tested that things still work as expected. |
|
Thanks for your work. Will review next week. |
|
ping? |
| "mesonbuild.testJobs": { | ||
| "type": "integer", | ||
| "default": -1, | ||
| "minimum": -1, | ||
| "description": "Specify the maximum number of tests executed in parallel. -1 for number of CPUs, 0 for unlimited." | ||
| }, |
There was a problem hiding this comment.
Instead of magic integers can we use strings to indicate unlimited and ncpus?
| // this is far from complete, but should suffice for the | ||
| // "test is made of a single executable is made of a single source file" usecase. |
There was a problem hiding this comment.
Are you going to complete this TODO
| function testAdder(test: vscode.TestItem) { | ||
| const mesonTest = mesonTests.find((mesonTest) => { | ||
| return mesonTest.name == test.id; | ||
| })!; | ||
| if (mesonTest.is_parallel) { | ||
| parallelTests.push(test); | ||
| } else { | ||
| sequentialTests.push(test); | ||
| } | ||
| // this way the total number of runs shows up from the beginning, | ||
| // instead of incrementing as individual runs finish | ||
| run.enqueued(test); | ||
| } |
There was a problem hiding this comment.
Can you make this an arrow function?
const xyz = ...
| const buildDir = workspaceState.get<string>("mesonbuild.buildDir")!; | ||
| const mesonTests = await getMesonTests(buildDir); | ||
|
|
||
| function testAdder(test: vscode.TestItem) { |
There was a problem hiding this comment.
Can you add a comment about what this function does?
| const running_tests: Promise<void>[] = []; | ||
| const max_running: number = (() => { | ||
| const jobs_config = extensionConfiguration("testJobs"); | ||
| switch (jobs_config) { |
There was a problem hiding this comment.
Please use camel case for naming
This adds parallel test execution through the vscode TestController API. Sequential tests
test(..., is_parallel = false)are respected.Parallelism is set to the number of CPUs, if desired I could also add a config option.
I also fixed output formatting of test failures as
vscode.TestRun.appendOutputalways expects CLRF.