fix: register cache_{k,v} as buffers in llama{3,4} #380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In recent versions of PyTorch, tensors initiated via
self.tensorin the init function are assumed to be constants, which do not change during the runtime of the inference. The role forcache_kandcache_vshould be non-persistent buffers, and be registered withself.register_buffer.The above creates problems for, e.g., the ONNX exporter. I encountered this error to exporting layers[0] of llama3:
This PR fixes the problem. It's also worth noticing that the llama3-multimodal already uses this approach.
The script I'm using