move weight update validation functions to util #573
+285
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JenniferWang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87005971. |
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 15, 2025
Summary: * Fix the weight update test * Extract common logic to a separate util function; see the next diff D87083010 for how to use them in verifying weights do get updated as part of infra verification when debugging a buggy run. Reviewed By: casteryh Differential Revision: D87005971
facebook-github-bot
force-pushed
the
export-D87005971
branch
from
97f8002 to
4d79c23
Compare
Summary: * Fix the weight update test * Extract common logic to a separate util function; see the next diff D87083010 for how to use them in verifying weights do get updated as part of infra verification when debugging a buggy run. Reviewed By: casteryh Differential Revision: D87005971
facebook-github-bot
force-pushed
the
export-D87005971
branch
from
4d79c23 to
9f23889
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Differential Revision: D87005971