Repository navigation
fix(utils): prevent createExcerpt from dropping text between colons #13102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abhi-byte62
wants to merge
2
commits into
meta:main
Choose a base branch
from
abhi-byte62:fix/excerpt-emoji-colons
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+29
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Continue removing digit-led emoji shortcodes.
For
Score :100: today.,:100:matches neither special alternative nor the letter-led alternative. It remains in the generated description, although the previous pattern removed it. Include recognized digit-led emoji names in the cleanup.The PR objective requires real emoji shortcodes to be removed.
Preserve colon-delimited text that is not an emoji.
For
Use :root:hover to style the page., the regex removes:root:and returnsUse hover to style the page.This corrupts the CSS selector in the generated description. Match known emoji names rather than every letter-led token.The PR objective requires ordinary colon-containing text to remain intact.
Remove shortcodes adjacent to letters.
For
Hello:wave: world., the lookbehind rejects:wave:because its opening colon followso. The generated description retains the shortcode; the previous pattern removed it. Handle adjacent emoji shortcodes without relying on this boundary.The PR objective requires real emoji shortcodes to be removed.