Skip to content

Support user login and registration #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Support user login and registration #495

wants to merge 26 commits into from

Conversation

amCap1712
Copy link
Member

TBA

@amCap1712 amCap1712 mentioned this pull request Dec 21, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 21, 2024 •
edited
Loading

Test Results

236 tests  +37   184 ✅  - 10   35s ⏱️ +8s
  1 suites ± 0     5 💤 ± 0 
  1 files   ± 0    47 ❌ +47 

For more details on these failures, see this check.

Results for commit a733c1c. ± Comparison against base commit 4003c6b.

This pull request removes 24 and adds 61 tests. Note that renamed tests count towards both. 
metabrainz.admin.views_test.AdminViewsTestCase ‑ test_index
metabrainz.supporter.views_test.SupportersViewsTestCase ‑ test_login
metabrainz.supporter.views_test.SupportersViewsTestCase ‑ test_logout
metabrainz.supporter.views_test.SupportersViewsTestCase ‑ test_musicbrainz
metabrainz.supporter.views_test.SupportersViewsTestCase ‑ test_musicbrainz_post
metabrainz.supporter.views_test.SupportersViewsTestCase ‑ test_signup
metabrainz.views_test.IndexViewsTestCase ‑ test_about
metabrainz.views_test.IndexViewsTestCase ‑ test_about_customers
metabrainz.views_test.IndexViewsTestCase ‑ test_bad_customers
metabrainz.views_test.IndexViewsTestCase ‑ test_code_of_conduct
…

metabrainz.admin.views_test.AdminViewsTestCase ‑ test_supporter_admin_index
metabrainz.admin.views_test.AdminViewsTestCase ‑ test_user_admin_index
metabrainz.index.views_test.IndexViewsTestCase ‑ test_about
metabrainz.index.views_test.IndexViewsTestCase ‑ test_about_customers
metabrainz.index.views_test.IndexViewsTestCase ‑ test_bad_customers
metabrainz.index.views_test.IndexViewsTestCase ‑ test_code_of_conduct
metabrainz.index.views_test.IndexViewsTestCase ‑ test_contact
metabrainz.index.views_test.IndexViewsTestCase ‑ test_dataset_download
metabrainz.index.views_test.IndexViewsTestCase ‑ test_dataset_signup
metabrainz.index.views_test.IndexViewsTestCase ‑ test_datasets
…

♻️ This comment has been updated with latest results.

@amCap1712 amCap1712 marked this pull request as ready for review September 17, 2025 13:46
@MonkeyDo
Copy link
Member

Reviewed and cleaned up the sign in and sign up pages (user and supporters, commercial and non-commercial)

Supporters
image
image

End users
image
image

amCap1712 and others added 24 commits October 16, 2025 21:51
@amCap1712
Support user login and registration
fafb366
@amCap1712
Fix existing tests
31ce07d
@amCap1712
add user view tests
39c838c
@amCap1712
Let admins block and unblock users
cb1ef8a 
Add a moderation log to keep track of decisions as well.
@amCap1712
remove ide files
84b4cef
@anshg1214 @amCap1712
feat: improve signup & login page
4c166c5
@MonkeyDo @amCap1712
Refactor conditions modal
26e20ec 
It was duplicated and unused on two pages
@anshg1214 @amCap1712
fix: forgot password page
7b1ea12
@amCap1712
add moderation comments
9796769
@amCap1712
add manual email verification and more standard template
5313857
@amCap1712
supporter fix
d0b79f3
@amCap1712
minor fixes
9719e00
@MonkeyDo @amCap1712
Fix missing close button BS styles
51ff574
@MonkeyDo @amCap1712
Hide password by default
11de8fd 
and add a button to show/hide the password
@MonkeyDo @amCap1712
Animate and reuse project logo pills
4a58226 
+ automatic formating
@MonkeyDo @amCap1712
Review conditions modal, add project logos
94089fd
@MonkeyDo @amCap1712
Make password hide buttons accessible
08f3f9b
@MonkeyDo @amCap1712
Use AuthCardPasswordInput for all password inputs
97b065a
@MonkeyDo @amCap1712
Rework signup/login pages UI
003106d 
Fix form validation and UI hints, rework the UI to be more user-friendly, cleanup markup, make it more mobile friendly
@MonkeyDo @amCap1712
Block button on login page
f4d8f41 
same as other pages, big call-to-action button as in the design files
@MonkeyDo @amCap1712
Block button on singup page
f45d8e9
@MonkeyDo @amCap1712
Add link to end-user singup from commercial signup pages\
e6e60f1 
We don't want end-users to create accounts directly on MeB.org, but it might just happen, so adding a link to the signup page they would be looking for.
@MonkeyDo @amCap1712
Add moderation_log to drop tables script
f0a3e14 
Otherwise the entire test suite fails
@amCap1712
add support for editing username
5d01e69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amCap1712 @MonkeyDo @anshg1214