Add notifications_enabled column, refactor digest-preference endpoint to notification-preference and some minor fixes #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ication-preference, fix linting issues
|
@mayhem PR ready for review. |
|
I'll try and have a look tomorrow -- I'm "mostly" on vacation this week. |
|
Sorry, not feeling great right now. Hopefully tomorrow. |
No worries ! |
|
This PR looks good to me, but the bits about the PG extension need to have a quick review from @amCap1712 |
amCap1712
reviewed
Oct 3, 2025
fettuccinae
force-pushed
the
notification_preference
branch
from
037a942 to
21b6d0c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a notifications_enabled column in user_preference table and related code in the endpoint, so that a user can set their notification preference, i.e if they want to receive email notifications immediately or in a digest.
They have 3 options now:
If notifications are disabled, they will be receiving only the important mails.
If notifications are enabled and digest is disabled, they will be receiving the mails(important and non important) immediately
If notifications are enabled and digest is enabled, they will be receiving the important mails directly and non-important mails in a digest.
Fixed linting issues (unused import and a semi colon)
Fixed the uuid extension missing bug by creating extensions in metabrainz db as the postgres user instead of creating them in the default postgres db.