MBS-13613: Show secondary art if no poster is available by IvanPisquiy06 · Pull Request #3731 · metabrainz/musicbrainz-server

IvanPisquiy06 · 2026-02-24T06:07:44Z

Problem

Currently, when an event lacks a Front artwork (Poster), the sidebar displays a generic "No poster available" placeholder, even if there are Flyer or Banner images associated with the event.

Solution

Implemented a fallback logic natively in the database query to display a Flyer (priority 1) or a Banner (priority 2) when the Front image is missing.

Modified Data::Role::Art::find_by_entity to dynamically update $extra_conditions and the ORDER BY clause when querying for an event entity with $opts{is_front}.
The SQL query now efficiently filters for Front (Poster), Flyer, or Banner using ANY(types) and sorts the results by priority (ORDER BY is_front DESC, 'Flyer' = ANY(...) DESC, 'Banner' = ANY(...) DESC, ordering).
This allows the database to handle the fallback logic and return the correct prioritized image in a single query, keeping MusicBrainz::Server::Controller::Event clean.

Testing

Tested locally on event pages by injecting mock event art records via SQL to verify the new ORDER BY logic:

Inserted a Flyer and Banner without a Front -> Verified Flyer is displayed.
Inserted only a Banner -> Verified Banner is displayed.
Inserted a Front and a Flyer -> Verified Front takes absolute priority.

Documenting

N/A

Further action

Future UX Improvement: As a follow-up, it would be great to pass the selected fallback type (e.g., "Flyer") to the React component and display it directly below the image in the sidebar. This would give users better context as to why they are not seeing a standard event poster.

Ticket MBS-13613: Currently only if an image is a Poster can be shown in SideBar of an event. This makes it that if no Poster available, a Flyer or next a Banner can be shown.

mwiencek

Thank you for the PR! You should be able to implement this more easily (without additional database queries) by updating $extra_conditions in Data::Role::Art::find_by_entity based on $entity_type. Plus the ORDER BY, so that it sorts things in "poster, flyer, banner" order.

Ticket MBS-13613: Past method required db queries. It now filters directly on find_by_entity and sorts it following the main hierarchy.

IvanPisquiy06 · 2026-02-24T23:47:15Z

Thanks for the feedback @mwiencek ! I changed the method following your advice. It was easier as you pointed out, appreciate it!
Let me know your thoughts on this version and thank you for taking the time!

mwiencek · 2026-02-25T19:34:34Z

    } $art_archive_model->art_archive_type_booleans);

    my $extra_conditions = '';
+    my $order_by = "ORDER BY $art_schema.index_listing.ordering";


You're not actually using $order_by anywhere in the query, so there's no sorting right now. (You can also remove ORDER BY from this string and leave it in the query, since it's always present.)

mwiencek · 2026-02-25T19:38:35Z

+            $extra_conditions .= " AND (is_front = TRUE OR 'Flyer' = ANY($art_schema.index_listing.types) OR 'Banner' = ANY($art_schema.index_listing.types))";
+
+            $order_by = "ORDER BY is_front DESC, 'Flyer' = ANY($art_schema.index_listing.types) DESC, 'Banner' = ANY($art_schema.index_listing.types) DESC, $art_schema.index_listing.ordering";
+        } else {


We try to keep lines under 80 chars. (A lot of existing code does go over that limit, but 193 chars is a bit too excessive.)

Suggested change

$extra_conditions .= " AND (is_front = TRUE OR 'Flyer' = ANY($art_schema.index_listing.types) OR 'Banner' = ANY($art_schema.index_listing.types))";

$order_by = "ORDER BY is_front DESC, 'Flyer' = ANY($art_schema.index_listing.types) DESC, 'Banner' = ANY($art_schema.index_listing.types) DESC, $art_schema.index_listing.ordering";

} else {

my $types_column = "$art_schema.index_listing.types";

$extra_conditions .= 'AND (' .

'is_front = TRUE ' .

"OR 'Flyer' = ANY($types_column) " .

"OR 'Banner' = ANY($types_column)" .

')';

$order_by = 'is_front DESC, ' .

"'Flyer' = ANY($types_column) DESC, " .

"'Banner' = ANY($types_column) DESC, " .

$order_by;

} else {

mwiencek · 2026-02-25T19:40:06Z

              {eventArtPresence === 'present' ? (
                <>
-                  {l('No poster available.')}
+                  {l('No main event art available.')}


Instead of "main," maybe we ought to stick with "front," since that's the prevalent terminology.

Ticket MBS-13613: The sub has_artwork_type is eliminated and find_by_entity code is cleaned for better organized and cleaner code

IvanPisquiy06 · 2026-02-26T01:36:38Z

You are right @mwiencek , now that you pointed it out it looks not that well organized and makes the code more readable. Thanks for the tips on making it cleaner. Will definitely apply this in the future.
Appreciate all the guidance on this issue!

mwiencek · 2026-03-13T14:18:04Z

    } $art_archive_model->art_archive_type_booleans);

    my $extra_conditions = '';
+    my $order_by = "$art_schema.index_listing.ordering";


You still aren't using this.

Thank you Michael! You're right, in next commit I'm adding it's use on line 134, I left the query instead of adding the variable $order_by so now it's fixed c:

mwiencek · 2026-03-13T14:20:18Z

+            my $types_column = "$art_schema.index_listing.types";
+
+            $extra_conditions .= ' AND ( ' .
+            ' is_front = TRUE' .


Sorry for the style nitpicking, but you're now missing indentation on the continuation lines here. The excessive newlines aren't needed either. Just see my previous suggestion. :)

Don't be! I'm really grateful that you take the time for me to learn how you work, specially if my plan is applying with you and need to get to know better the code and practices! c:

mwiencek · 2026-03-13T14:24:08Z

              {eventArtPresence === 'present' ? (
                <>
-                  {l('No poster available.')}
+                  {l('No front art available.')}


"No front event art available" was my suggestion. We use "front cover art" for releases so it probably makes sense to specify event here.

Sorry! I misunderstood the suggestion. Thank's for pointing it out, the change is made so shouldn't be anymore issues on this matter.

Ticket MBS-13613: find_by_entity had issues on identation on query and variable that was not used. Fixed for better practices and correct function.

Show secondary art if no poster is available

a4c28aa

Ticket MBS-13613: Currently only if an image is a Poster can be shown in SideBar of an event. This makes it that if no Poster available, a Flyer or next a Banner can be shown.

mwiencek requested changes Feb 24, 2026

View reviewed changes

Changing method on how to retrieve the event art type

c7cacd9

Ticket MBS-13613: Past method required db queries. It now filters directly on find_by_entity and sorts it following the main hierarchy.

IvanPisquiy06 requested a review from mwiencek February 24, 2026 23:51

mwiencek requested changes Feb 25, 2026

View reviewed changes

Cleaning code for better practices

d89ff55

Ticket MBS-13613: The sub has_artwork_type is eliminated and find_by_entity code is cleaned for better organized and cleaner code

IvanPisquiy06 requested a review from mwiencek February 26, 2026 01:37

mwiencek requested changes Mar 13, 2026

View reviewed changes

Fixing sort on arts and identation

a0d9da8

Ticket MBS-13613: find_by_entity had issues on identation on query and variable that was not used. Fixed for better practices and correct function.

IvanPisquiy06 requested a review from mwiencek March 15, 2026 04:44

-            $extra_conditions .= " AND (is_front = TRUE OR 'Flyer' = ANY($art_schema.index_listing.types) OR 'Banner' = ANY($art_schema.index_listing.types))";
-            $order_by = "ORDER BY is_front DESC, 'Flyer' = ANY($art_schema.index_listing.types) DESC, 'Banner' = ANY($art_schema.index_listing.types) DESC, $art_schema.index_listing.ordering";
-        } else {
+            my $types_column = "$art_schema.index_listing.types";
+            $extra_conditions .= 'AND (' .
+                'is_front = TRUE ' .
+                "OR 'Flyer' = ANY($types_column) " .
+                "OR 'Banner' = ANY($types_column)" .
+            ')';
+            $order_by = 'is_front DESC, ' .
+                "'Flyer' = ANY($types_column) DESC, " .
+                "'Banner' = ANY($types_column) DESC, " .
+                $order_by;
+        } else {

Uh oh!

Conversation

IvanPisquiy06 commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Solution

Testing

Documenting

Further action

Uh oh!

mwiencek left a comment

Choose a reason for hiding this comment

Uh oh!

IvanPisquiy06 commented Feb 24, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

IvanPisquiy06 commented Feb 26, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IvanPisquiy06 commented Feb 24, 2026 •

edited

Loading