MBS-14316: Validate event times at the JS level#3759
Open
reosarevok wants to merge 1 commit into
Open
Conversation
We were only validating event times at the Perl level. But when a Perl error was returned, since errors block form submission, there was no way to correct it and submit the form. This moves validation to happen primarily at the JS level in form state. We keep the validation on Perl as well as a fallback, as with other form validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix MBS-14316
Problem
We are only validating event times at the Perl level. But when a Perl error is returned, since errors block form submission, there is no way to correct it and submit the form.
Solution
This moves validation to happen primarily at the JS level in form state. We keep the validation on Perl as well as a fallback, as with other form validation.
AI usage
None
Testing
Added a test for the JS version of
isValidTime, plus tested editing an event manually a bit.