Docker and GitHub Action updates #3373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
haarg
commented
Jun 2, 2025
haarg
commented
- smaller image for asset building
- use timestamp tags for metacpan-base rather than latest
- add dependabot updates for docker
- support slim builds (about 1/3 the size)
- various other small changes
haarg
force-pushed
the
haarg/docker-and-actions-updates
branch
3 times, most recently
from
9429c35 to
5e3472f
Compare
oalders
force-pushed
the
haarg/docker-and-actions-updates
branch
from
5e3472f to
f06bae1
Compare
oalders
reviewed
Jun 4, 2025
.github/workflows/test.yml
Outdated
| @@ -77,7 +77,7 @@ jobs: | |||
| load: true | |||
| - name: Run Perl tests | |||
| run: > | |||
| docker run -d -i -p 8000:80 | |||
| docker run -d -i -p 8000:8000 | |||
There was a problem hiding this comment.
I think these may need to be changed to 5001? I just merged that change to the port number. 😢
oalders
previously approved these changes
Jun 4, 2025
Using a separate build stage allows Docker to cache the build results separately from the rest of the build. It also can allow the CPAN building and the main server image to use separate base images.
Slim builds don't incude a compiler or other development tools. The tag name of the slim build may not match the non-slim build exactly, so we need to list both. Installing the CPAN prereqs still needs the non-slim build.
Catalyst no longer warns about Term::Size::Any being missing if COLUMNS is set.
haarg
force-pushed
the
haarg/docker-and-actions-updates
branch
from
f06bae1 to
ab6d690
Compare
oalders
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.