-
Notifications
You must be signed in to change notification settings - Fork 33
DRAFT: Test/simplify transformation tests #749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
DRAFT: Test/simplify transformation tests #749
Conversation
antagomir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems good so far
TuomasBorman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks! See comments
TuomasBorman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does right things but only for small part of tests. For those transformations that come from vegan, only one test is needed, i.e., test that checks that transformAssay equals to vegan::decostand (test that mia do not introduce errors when calling the function)
Reviewing mia unit tests. Related issue #748
Opening a draft PR to receive ongoing feedback to confirm correct direction/intent.