Skip to content

Conversation

@raivo-otus
Copy link
Contributor

Reviewing mia unit tests. Related issue #748

Opening a draft PR to receive ongoing feedback to confirm correct direction/intent.

Copy link
Member

@antagomir antagomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good so far

Copy link
Contributor

@TuomasBorman TuomasBorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! See comments

Copy link
Contributor

@TuomasBorman TuomasBorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does right things but only for small part of tests. For those transformations that come from vegan, only one test is needed, i.e., test that checks that transformAssay equals to vegan::decostand (test that mia do not introduce errors when calling the function)

@raivo-otus raivo-otus marked this pull request as ready for review December 16, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants