Remove redundant sorted check before Arrays.sort() #6847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arrays.sort() uses TimSort which is already optimized for sorted arrays with O(n) best-case complexity. The pre-sort check adds unnecessary overhead for unsorted data (common case) without significant benefit. Simplified toKeyValues() and toTags() by removing isSortedSet() method and relying on TimSort's adaptive sorting behavior. Signed-off-by: David Mollitor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the isSortedSet() pre-check before calling Arrays.sort() in both KeyValues and Tags classes. Modern JVM implementations make this optimization unnecessary and potentially counterproductive
Arrays.sort() uses TimSort which is already optimized for sorted arrays with O(n) best-case complexity. The pre-sort check adds unnecessary overhead for unsorted data (common case) without significant benefit.
length = array.length. The check if(length > array.length)could never be true, making this guard condition pointless.