Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add failing test #1331

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
package io.micronaut.function.aws.proxy.test

import io.micronaut.context.annotation.Property
import io.micronaut.context.annotation.Requires
import io.micronaut.http.HttpRequest
import io.micronaut.http.HttpResponse
import io.micronaut.http.HttpStatus
import io.micronaut.http.MediaType
import io.micronaut.http.annotation.Controller
import io.micronaut.http.annotation.Get
import io.micronaut.http.annotation.Status
import io.micronaut.http.client.HttpClient
import io.micronaut.http.client.annotation.Client
import io.micronaut.test.extensions.spock.annotation.MicronautTest
import jakarta.inject.Inject
import spock.lang.PendingFeature
import spock.lang.Specification

@Property(name = 'spec.name', value = 'ContentTypeSpec')
@MicronautTest
class ContentTypeSpec extends Specification {

@Inject
@Client("/")
HttpClient httpClient

@PendingFeature
void "verify controllers return json by default"() {
given:
HttpRequest<?> request = HttpRequest.GET('/json/bydefault').accept(MediaType.APPLICATION_JSON)

when:
HttpResponse<String> response = httpClient.toBlocking().exchange(request, String)

then:
HttpStatus.OK == response.status()
response.body.get() == '{"msg":"Hello world"}'
response.headers
"application/json" == response.headers.get("Content-Type")
}

@Controller('/json')
@Requires(property = 'spec.name', value = 'ContentTypeSpec')
static class BodyController {

@Get("/bydefault")
@Status(HttpStatus.OK)
Map<String, Object> index() {
[msg: "Hello world"]
}
}
}

Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
package io.micronaut.function.aws.proxy

import com.amazonaws.serverless.proxy.internal.testutils.AwsProxyRequestBuilder
import com.amazonaws.serverless.proxy.internal.testutils.MockLambdaContext
import com.amazonaws.serverless.proxy.model.AwsProxyResponse
import com.amazonaws.services.lambda.runtime.Context
import io.micronaut.context.ApplicationContext
import io.micronaut.context.annotation.Requires
import io.micronaut.http.HttpHeaders
import io.micronaut.http.HttpMethod
import io.micronaut.http.HttpStatus
import io.micronaut.http.MediaType
import io.micronaut.http.annotation.Body
import io.micronaut.http.annotation.Controller
import io.micronaut.http.annotation.Get
import io.micronaut.http.annotation.Post
import io.micronaut.http.annotation.Status
import spock.lang.AutoCleanup
import spock.lang.Issue
import spock.lang.PendingFeature
import spock.lang.Shared
import spock.lang.Specification

class ContentTypeSpec extends Specification {
@Shared
@AutoCleanup
MicronautLambdaContainerHandler handler = new MicronautLambdaContainerHandler(
ApplicationContext.builder().properties([
'spec.name' : 'ContentTypeSpec',
'micronaut.security.enabled': false,
])
)
@Shared
Context lambdaContext = new MockLambdaContext()

@Issue("https://github.com/micronaut-projects/micronaut-aws/issues/1330")
@PendingFeature
void "verify controllers return json by default"() {
given:
AwsProxyRequestBuilder builder = new AwsProxyRequestBuilder('/json/bydefault', HttpMethod.GET.toString())
builder.header(HttpHeaders.ACCEPT, MediaType.APPLICATION_JSON)

when:
AwsProxyResponse response = handler.proxy(builder.build(), lambdaContext)

then:
response.statusCode == 200
response.body == '{"msg":"Hello world"}'
response.headers
"application/json" == response.getHeaders().get("Content-Type")
}

@Controller('/json')
@Requires(property = 'spec.name', value = 'ContentTypeSpec')
static class BodyController {

@Get("/bydefault")
@Status(HttpStatus.OK)
Map<String, Object> index() {
[msg: "Hello world"]
}
}
}