Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proxy-test property sources to lambda handler ctx #1337

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Apr 4, 2022

See #1330

Without this PR, you cannot use a @Requires annotation for an @Property - the typical spec.name pattern to avoid bean pollution. Because the api-proxy-test appliation context property sources are differnet than the MicronautLambdaHandler property sources.

@sdelamo sdelamo added the type: bug Something isn't working label Apr 4, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sdelamo sdelamo requested a review from graemerocher April 4, 2022 11:29
@sdelamo
Copy link
Contributor Author

sdelamo commented Apr 11, 2022

@graemerocher can you review this?

@sdelamo sdelamo merged commit 6a4bf9f into 3.2.x Apr 12, 2022
@sdelamo sdelamo deleted the fix-proxy-test-context-property-sources branch April 12, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants