-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: multi value header handling #1888
Conversation
ping @driverpt |
import spock.lang.Specification | ||
|
||
@MicronautTest | ||
class MapCollapseUtilsSpec extends Specification { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The examples Foo
and Key
in this test are taken directly from the AWS Lambda Console. I did request and logged them to see how they are represented in the Lambda Event Objects.
@@ -31,6 +35,8 @@ | |||
@Internal | |||
public final class MapCollapseUtils { | |||
|
|||
private static final List<String> HEADERS_ALLOWING_COMMAS = Arrays.asList(HttpHeaders.DATE, HttpHeaders.USER_AGENT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be configurable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see how Netty handles this @yawkat do you know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be configurable?
but it should be configurable at not in AWS right?, should this configuration be in servlet-core?
SonarCloud Quality Gate failed.
|
Close #1861
Multi-header values should use a comma:
But there are headers which have a , without using it to designate a multi-value. E.g. Date. Thus, a mess 🤷🏼♂️