Use Built-in Java HTTP Server instead of Jetty 11 #2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdelamo
commented
Mar 19, 2025
| import java.util.concurrent.atomic.AtomicBoolean; | ||
|
|
||
| @Internal | ||
| class HttpServerEmbeddedServer implements EmbeddedServer { |
There was a problem hiding this comment.
@graemerocher @yawkat I would like to move this class to core. What do you think? That way I could use it in every cloud module (aws, gcp, azure).
There was a problem hiding this comment.
or maybe in servlet.
sdelamo
force-pushed
the
built-in-http-server
branch
from
bd0afdc to
9aa83fe
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jetty 11 has a CVE. This pull request removes the usage of Jetty 11 and replaces it with the built-in Java HTTP Server.
Jetty 12 Handler uses
org.eclipse.jetty.server.Requestinstead ofjakarta.servlet.http.HttpServletRequest.org.eclipse.jetty.server.Requestno longer implementsHttpServletRequest. Because of that, to get rid of Jetty 11, we had two options: rewrite to Jetty 12 or migrateAwsApiProxyTestServerto use the Java Built-in HTTP Server and remove the usage of Jetty.I gone the path of using the built-in HTTP Server. There are several classes introduced in this PR which I think should be in micronaut core.