Fix many-to-one (and one-to-one) join #3337
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radovanradic
commented
Mar 3, 2025
| @@ -92,7 +92,7 @@ class CriteriaSpec extends AbstractCriteriaSpec { | |||
| String query = getSqlQuery(criteriaQuery) | |||
|
|
|||
| expect: | |||
| query == '''SELECT book_."id",book_."author_id",book_."title",book_."total_pages",book_."last_updated" FROM "book" book_ WHERE (book_."id" IN (SELECT book_book_."id" FROM "book" book_book_ WHERE (book_book_."id" = 123)))''' | |||
There was a problem hiding this comment.
Does not return field from the association if not requested by join for retrieval
radovanradic
commented
Mar 3, 2025
| @@ -524,7 +524,7 @@ interface BookRepository extends GenericRepository<Book, Long> { | |||
| when: | |||
| def updateReturningCustomMethod = repository.findPossibleMethods("updateReturning").findFirst().get() | |||
| then: | |||
| getQuery(updateReturningCustomMethod) == 'UPDATE "book" SET "author_id"=?,"genre_id"=?,"title"=?,"total_pages"=?,"publisher_id"=?,"last_updated"=? WHERE ("id" = ?) RETURNING "id","author_id","genre_id","title","total_pages","publisher_id","last_updated"' | |||
There was a problem hiding this comment.
Returning also returns only fields belonging to the entity. This might be the most significant change, not sure if returning could have @Join annotation to tell Micronaut Data to return joined entities?
radovanradic
changed the title
dstepanov
reviewed
Mar 5, 2025
data-tck/src/main/java/io/micronaut/data/tck/entities/SaleItem.java
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be the fix for issue. The idea is not
SELECTentity id for many-to-one and one-to-one relation and onlySELECTentity and its fields if joined.However, it does change previous behavior and does not select entities with just id for many-to-one, one-to-one, which I think is correct way and fixes original issue).