Implement @JsonInclude(content=
#1050
Conversation
| return false; | ||
| } | ||
| } catch (SerdeException e) { | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
need to throw a more specific exception here
There was a problem hiding this comment.
What I mean was a more specific exception type. If this is a configuration error maybe ConfigurationException?
There was a problem hiding this comment.
I have added a sneaky throw so the original exception is thrown withou changes
| @@ -82,53 +82,4 @@ class Test { | |||
| context.close() | |||
| } | |||
|
|
|||
| void "test json any getter / setter - records"() { | |||
There was a problem hiding this comment.
I assume these deleted tests were moved to the TCK?
| @@ -103,6 +104,22 @@ public void serializeInto(Encoder encoder, EncoderContext context, Argument<? ex | |||
| default: | |||
| // fall through | |||
| } | |||
| if (property.include != SerdeConfig.SerInclude.ALWAYS && property.include != SerdeConfig.SerInclude.NON_NULL) { | |||
| switch (property.includeContent) { | |||
There was a problem hiding this comment.
I don't think jackson does it this way
There was a problem hiding this comment.
There was a problem hiding this comment.
Removed the common methods and logic and moved it to the optional
There was a problem hiding this comment.
It's a bit strange that you cannot exclude empty values from List
| @@ -48,6 +48,11 @@ public String deserializeNullable(@NonNull Decoder decoder, @NonNull DecoderCont | |||
| return decoder.decodeStringNullable(); | |||
| } | |||
|
|
|||
| @Override | |||
| public boolean isAbsent(EncoderContext context, String value) { | |||
| return value == null; | |||
There was a problem hiding this comment.
From the JsonInclude javadoc, I think this should be the default impl of isAbsent for all types: https://www.javadoc.io/doc/com.fasterxml.jackson.core/jackson-annotations/latest/com/fasterxml/jackson/annotation/JsonInclude.Include.html#NON_ABSENT
There was a problem hiding this comment.
Yeah it's the same as the super method
|
No description provided.