Use env var for scope similar to dotnet sdk.#22
Merged
sellakumaran merged 8 commits intomainfrom Nov 4, 2025
Merged
Conversation
sellakumaran
requested review from
juliomenendez,
nikhilNava,
pontemonti and
rahuldevikar761
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for configuring the authentication scope via an environment variable MCP_PLATFORM_AUTHENTICATION_SCOPE in the AgenticAuthenticationService. This allows runtime customization of the scope used for token exchange instead of always using the hardcoded default scope.
- Extracts scope determination logic into a new private static method
getScope() - Adds support for environment variable
MCP_PLATFORM_AUTHENTICATION_SCOPEto override the default scope - Falls back to the existing default scope format when the environment variable is not set
packages/agents-a365-runtime/src/agentic-authorization-service.ts
Outdated
Show resolved
Hide resolved
packages/agents-a365-runtime/src/agentic-authorization-service.ts
Outdated
Show resolved
Hide resolved
joratz
previously approved these changes
Nov 3, 2025
packages/agents-a365-runtime/src/agentic-authorization-service.ts
Outdated
Show resolved
Hide resolved
joratz
previously approved these changes
Nov 3, 2025
pontemonti
reviewed
Nov 3, 2025
pontemonti
reviewed
Nov 3, 2025
packages/agents-a365-runtime/src/agentic-authorization-service.ts
Outdated
Show resolved
Hide resolved
pontemonti
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use env var for scope similar to dotnet sdk.