Closed
Conversation
Contributor
JesuTerraz
commented
Nov 3, 2025
- Makes authToken optional. If not provided, the registration service will attempt to authenticate using Agents SDK agentic auth
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds default empty string values to the authToken parameter across three MCP tool registration service implementations. This change ensures the parameter is optional while maintaining backward compatibility.
- Changed the
authTokenparameter to have a default value of empty string in three service classes - Maintains existing logic that fetches a token if none is provided
- Applies the same pattern consistently across OpenAI, LangChain, and Claude extensions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/agents-a365-tooling-extensions-openai/src/McpToolRegistrationService.ts | Added default empty string value to authToken parameter in addMcpToolServers method |
| packages/agents-a365-tooling-extensions-langchain/src/McpToolRegistrationService.ts | Added default empty string value to authToken parameter in addMcpToolServers method |
| packages/agents-a365-tooling-extensions-claude/src/McpToolRegistrationService.ts | Added default empty string value to authToken parameter in addToolServers method |
mrunalhirve128
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.