Skip to content

Adding agentic auth for Agent Framework #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrunalhirve128 merged 7 commits into from
Nov 4, 2025
Merged

Adding agentic auth for Agent Framework #10

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5d811a1
Add agentic auth for AF
mrunalhirve128 Nov 3, 2025
3978d56
fix
mrunalhirve128 Nov 3, 2025
75a12a8
format
mrunalhirve128 Nov 3, 2025
03f49fe
Merge branch 'main' of https://github.com/microsoft/Agent365-python i…
mrunalhirve128 Nov 3, 2025
2b421e4
add env changes
mrunalhirve128 Nov 3, 2025
47f6e1a
Merge branch 'main' of https://github.com/microsoft/Agent365-python i…
mrunalhirve128 Nov 4, 2025
6739f20
PR comments
mrunalhirve128 Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions ...t_agents_a365/tooling/extensions/agentframework/services/mcp_tool_registration_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@
)
from microsoft_agents_a365.tooling.utils.constants import Constants

from microsoft_agents_a365.tooling.utils.utility import (
get_ppapi_token_scope,
Comment thread
mrunalhirve128 marked this conversation as resolved.
Outdated
get_use_environment_id,
Comment thread
mrunalhirve128 marked this conversation as resolved.
)


class McpToolRegistrationService:
"""
Expand Down Expand Up @@ -43,9 +48,9 @@ async def add_tool_servers_to_agent(
initial_tools: List[Any],
agent_user_id: str,
environment_id: str,
auth: Optional[Authorization] = None,
auth: Authorization,
turn_context: TurnContext,
Comment thread
mrunalhirve128 marked this conversation as resolved.
auth_token: Optional[str] = None,
turn_context: Optional[TurnContext] = None,
) -> Optional[ChatAgent]:
"""
Add MCP tool servers to a chat agent (mirrors .NET implementation).
Expand All @@ -56,14 +61,20 @@ async def add_tool_servers_to_agent(
initial_tools: List of initial tools to add to the agent
agent_user_id: Unique identifier for the agent user
environment_id: Environment identifier for MCP server discovery
auth: Optional authorization context
auth: Authorization context for token exchange
turn_context: Turn context for the operation
auth_token: Optional bearer token for authentication
turn_context: Optional turn context for the operation

Returns:
ChatAgent instance with MCP tools registered, or None if creation failed
"""
try:
# Exchange token if not provided
if not auth_token:
scopes = get_ppapi_token_scope()
authToken = await auth.exchange_token(turn_context, scopes, "AGENTIC")
auth_token = authToken.token

self._logger.info(
f"Listing MCP tool servers for agent {agent_user_id} in environment {environment_id}"
)
Expand Down Expand Up @@ -96,7 +107,7 @@ async def add_tool_servers_to_agent(
headers[Constants.Headers.AUTHORIZATION] = (
f"{Constants.Headers.BEARER_PREFIX} {auth_token}"
)
if environment_id:
if get_use_environment_id() and environment_id:
headers[Constants.Headers.ENVIRONMENT_ID] = environment_id

server_name = getattr(config, "mcp_server_name", "Unknown")
Expand Down
Loading