Skip to content

feat: fixed leak#3298

Closed
vcharmcaster wants to merge 6 commits intomicrosoft:mainfrom
vcharmcaster:feature/leakFix
Closed

feat: fixed leak#3298
vcharmcaster wants to merge 6 commits intomicrosoft:mainfrom
vcharmcaster:feature/leakFix

Conversation

@vcharmcaster
Copy link
Copy Markdown

Fix # leaks in unit test

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed
  • CHANGELOG.md updated

@vcharmcaster
Copy link
Copy Markdown
Author

@vcharmcaster please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Copy link
Copy Markdown
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @vcharmcaster, I'd suggest reverting the try-with-resources around the (mock) exporters, since those are known to not require closing, and avoids additional indentation.

then will review the remaining, thx!

@vcharmcaster
Copy link
Copy Markdown
Author

hi @vcharmcaster, I'd suggest reverting the try-with-resources around the (mock) exporters, since those are known to not require closing, and avoids additional indentation.

then will review the remaining, thx!

updated

@trask trask closed this Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants