add RESOURCE_PROCESSOR_VMSS_SKU to inputs converted to TF_VAR_#4936
Conversation
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 7c2df1b. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Pull request overview
This PR extends the CI/CD workflow inputs-to-TF_VAR_ conversion so resource_processor_vmss_sku can be overridden via GitHub Environment variables (in addition to config.yaml), enabling E2E runs in regions where the default VM size isn’t available.
Changes:
- Pass
RESOURCE_PROCESSOR_VMSS_SKUfrom GitHub environment variables into the reusable deploy workflow. - Add a corresponding input to the
devcontainer_run_commandcomposite action and map it toTF_VAR_resource_processor_vmss_skuwith a default ofStandard_B2s. - Document the new GitHub variable in setup docs (with some doc fixes still needed).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/tre-admins/setup-instructions/workflows.md | Documents RESOURCE_PROCESSOR_VMSS_SKU for workflow-based deployments. |
| docs/tre-admins/setup-instructions/cicd-pre-deployment-steps.md | Documents RESOURCE_PROCESSOR_VMSS_SKU for CI/CD pre-deployment steps. |
| docs/tre-admins/environment-variables.md | Updates environment variable reference (currently introduces a duplicate row that needs consolidation). |
| .github/workflows/deploy_tre_reusable.yml | Wires GitHub env var RESOURCE_PROCESSOR_VMSS_SKU into the action inputs. |
| .github/actions/devcontainer_run_command/action.yml | Adds action input and exports TF_VAR_resource_processor_vmss_sku for Terraform usage. |
|
Not run test (smoke) as that will run the workflows/actions from the main branch and not pick up the changes in this PR. https://github.com/microsoft/AzureTRE/actions/runs/27815402091 suggesting we test-force-approve |
marrobi
left a comment
marrobi
left a comment
There was a problem hiding this comment.
LGTM - agree, force approve this.
|
/test-force-approve |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 7e98ecf) (in response to this comment from @ChrisChapman-gh) |
jonnyry
left a comment
jonnyry
left a comment
There was a problem hiding this comment.
LGTM. Just the CHANGELOG to update
|
Thanks @jonnyry, change log updated. |
|
/test-force-approve |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 7c2df1b) (in response to this comment from @ChrisChapman-gh) |
#4934
What is being addressed
Allowing resource_processor_vmss_sku to be set from GitHub vars as well as via config.yaml
How is this addressed
Following the pattern established for resource_processor_number_processes_per_instance