Skip to content

Fix build error with GCC by forcing Clang in CMake on android/aarch64 #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

Benjamin-Wegener
Copy link
Contributor

GCC does not recognize Clang-specific warning flags like -Wunreachable-code-break and -Wunreachable-code-return, which are passed by upstream submodules (e.g., ggml). This patch forces CMake to use Clang via command-line arguments, avoiding the need to patch nested submodules.

This resolves compiler errors without modifying submodule source code.

…d/aarch64

GCC does not recognize Clang-specific warning flags like
-Wunreachable-code-break and -Wunreachable-code-return, which are passed
by upstream submodules (e.g., ggml). This patch forces CMake to use Clang
via command-line arguments, avoiding the need to patch nested submodules.

This resolves compiler errors without modifying submodule source code.
@Benjamin-Wegener Benjamin-Wegener mentioned this pull request May 1, 2025
@Benjamin-Wegener
Copy link
Contributor Author

#241

@sd983527 sd983527 merged commit c9e752c into microsoft:main May 8, 2025
1 check passed
@Benjamin-Wegener Benjamin-Wegener deleted the gcc-fix branch May 8, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants