fix: Standardization of parameters and update workflows and documentation#145
Open
Prachig-Microsoft wants to merge 12 commits intodevfrom
Open
fix: Standardization of parameters and update workflows and documentation#145Prachig-Microsoft wants to merge 12 commits intodevfrom
Prachig-Microsoft wants to merge 12 commits intodevfrom
Conversation
- Reverted containerRegistryHost to use AZURE_CONTAINER_REGISTRY_HOST - Reverted AI model parameters to use AZURE_AI_MODEL_NAME, AZURE_AI_MODEL_VERSION, AZURE_AI_MODEL_CAPACITY - Reverted deployment type to use AZURE_AI_DEPLOYMENT_TYPE - Removed enableTelemetry parameter customization (uses bicep default) - Updated workflow files and documentation to reflect original naming - Kept AZURE_ENV_ prefix only for: AI_SERVICE_LOCATION, LOG_ANALYTICS_WORKSPACE_RID, FOUNDRY_PROJECT_RID, VM_ADMIN credentials, IMAGETAG
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes how AI service locations and existing resource IDs are passed through AZD deployments by renaming key environment variables, removing redundant parameters, and aligning infra templates, workflows, and docs to the updated naming.
Changes:
- Updated infra parameter files to use standardized env var names (notably
AZURE_ENV_AI_SERVICE_LOCATION,AZURE_ENV_LOG_ANALYTICS_WORKSPACE_RID,AZURE_ENV_FOUNDRY_PROJECT_RID) and removed deprecated/redundant parameters. - Removed the
aiDeploymentLocationparameter from Bicep/ARM (and corresponding CI invocation). - Updated GitHub deployment workflows and documentation to reflect the new env var names.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
infra/main.waf.parameters.json |
Switches AI location and existing resource ID env vars to standardized names. |
infra/main.parameters.json |
Same standardization for non-WAF parameters; drops deprecated/redundant entries. |
infra/main.json |
Regenerated ARM template; removes aiDeploymentLocation parameter. |
infra/main.bicep |
Removes aiDeploymentLocation parameter definition. |
docs/re-use-log-analytics.md |
Updates env var name for reusing an existing Log Analytics workspace. |
docs/re-use-foundry-project.md |
Updates env var name for reusing an existing Foundry project. |
docs/CustomizingAzdParameters.md |
Updates the parameter list to reflect new standardized env vars. |
.github/workflows/job-deploy-windows.yml |
Sets standardized env vars (AI location + existing resource IDs) during deployment. |
.github/workflows/job-deploy-linux.yml |
Sets standardized env vars (AI location + existing resource IDs) during deployment. |
.github/workflows/ci.yml |
Removes the now-deleted aiDeploymentLocation parameter from CI validation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Changed all workflow inputs from AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID to AZURE_ENV_LOG_ANALYTICS_WORKSPACE_RID - Ensures consistency with parameter files and documentation - Affected files: deploy-orchestrator.yml, deploy-v2.yml, job-deploy.yml, job-deploy-linux.yml, job-deploy-windows.yml
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Prachig-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Prachig-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
…_PROJECT_RID to AZURE_EXISTING_AIPROJECT_RESOURCE_ID and AZURE_ENV_LOG_ANALYTICS_WORKSPACE_RID to AZURE_ENV_EXISTING_LOG_ANALYTICS_WORKSPACE_RID
…rkflow validation Update validation logic and error messages in deploy-v2.yml, job-deploy-linux.yml, and job-deploy-windows.yml to use the renamed AZURE_EXISTING_AIPROJECT_RESOURCE_ID consistently. Previously, validation referenced the old AI_PROJECT_RESOURCE_ID name causing validation to silently skip. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The uv installer script requires awk for checksum verification. Without it, the build fails with 'checksum mismatch' due to missing awk command on Azure Linux base images. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…n-Solution-Accelerator into psl-prachi-params
Prachig-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Prachig-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Prachig-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Prachig-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Prachig-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
Prachig-Microsoft
requested review from
Dongbumlee,
dgp10801,
nchandhi,
sethsteenken and
toherman-msft
as code owners
Prachig-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Prachig-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates how AI service and resource IDs are handled throughout the deployment workflows, infrastructure templates, and documentation. The main goal is to standardize environment variable naming (especially for AI service locations and resource IDs), remove deprecated or redundant parameters, and ensure consistency across Linux/Windows workflows, Bicep/ARM templates, and documentation.
Key changes include:
These changes help ensure consistency, reduce confusion, and make it easier to manage and reuse AI-related resources in different environments.] No
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information