Fix PAQ memory leak by never pushing redundant stages to backing vector #7442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spall
reviewed
Oct 20, 2025
| } | ||
|
|
||
| // mod.ShaderStages can only take four elements before it starts to | ||
| // migrate. Make sure not to add redundant stages. |
There was a problem hiding this comment.
we could exit the while loop early here if mod.size() is 4?
bogner
reviewed
Oct 20, 2025
Comment on lines
+402
to
+403
| // mod.ShaderStages can only take four elements before it starts to | ||
| // migrate. Make sure not to add redundant stages. |
There was a problem hiding this comment.
If the problem is that we leak memory if the ShaderStages SmallVector ever grows, then wouldn't a better fix be to avoid a SmallVector (or any type that can move its memory) entirely? That is, should we adjust PayloadAccessAnnotation to store the stages in a fixed data structure instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backing memory of the
ShaderStagesvector starts to migrate when more than four stages are pushed. ASAN detects and errs on that condition (details in bug).Closes #7104