-
Notifications
You must be signed in to change notification settings - Fork 558
BaseContainerRuntimeFactoryProps input #25825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BaseContainerRuntimeFactoryProps input #25825
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds an @input tag to the documentation of BaseContainerRuntimeFactory construction properties. The change updates the JSDoc comment to include this additional metadata tag alongside the existing @legacy and @beta tags.
packages/framework/aqueduct/src/container-runtime-factories/baseContainerRuntimeFactory.ts
Show resolved
Hide resolved
|
The PR description says "Mark BaseContainerRuntimeFactoryProps as import" instead of "Mark BaseContainerRuntimeFactoryProps as input" |
type: import -> input |
|
🔗 Found some broken links! 💔 Run a link check locally to find them. See linkcheck output |
Description
Mark BaseContainerRuntimeFactoryProps as input to properly capture its intended use and therefore explicitly allow future optional items to be added (as was done with minVersionForCollab).
Reviewer Guidance
The review process is outlined on this wiki page.