Skip to content

Conversation

@CraigMacomber
Copy link
Contributor

@CraigMacomber CraigMacomber commented Nov 6, 2025

Description

Mark BaseContainerRuntimeFactoryProps as input to properly capture its intended use and therefore explicitly allow future optional items to be added (as was done with minVersionForCollab).

Reviewer Guidance

The review process is outlined on this wiki page.

Copilot AI review requested due to automatic review settings November 6, 2025 03:21
@github-actions github-actions bot added area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: main PRs targeted against main branch labels Nov 6, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an @input tag to the documentation of BaseContainerRuntimeFactory construction properties. The change updates the JSDoc comment to include this additional metadata tag alongside the existing @legacy and @beta tags.

@yann-achard-MS
Copy link
Contributor

The PR description says "Mark BaseContainerRuntimeFactoryProps as import" instead of "Mark BaseContainerRuntimeFactoryProps as input"

@agarwal-navin
Copy link
Contributor

Description

Mark BaseContainerRuntimeFactoryProps as import to properly capture its intended use and therefore explicitly allow future optional items to be added (as was done with minVersionForCollab).

type: import -> input

@CraigMacomber CraigMacomber requested a review from a team as a code owner November 7, 2025 18:10
@github-actions github-actions bot added the public api change Changes to a public API label Nov 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

🔗 Found some broken links! 💔

Run a link check locally to find them. See
https://github.com/microsoft/FluidFramework/wiki/Checking-for-broken-links-in-the-documentation for more information.

linkcheck output


> [email protected] ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

 ELIFECYCLE  Command failed with exit code 1.

@CraigMacomber CraigMacomber merged commit 609f0b7 into microsoft:main Nov 10, 2025
37 checks passed
@CraigMacomber CraigMacomber deleted the BaseContainerRuntimeFactoryPropsInput branch November 10, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: main PRs targeted against main branch public api change Changes to a public API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants