Skip to content

Stop calls to addGifFrameAsyncDelay to prevent collection of screenshots #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 26, 2025

Conversation

ASPS002
Copy link
Collaborator

@ASPS002 ASPS002 commented Mar 25, 2025

Description

This Pull request makes use of disableGifEncoder to avoid calls to addGifFrameAsyncDelay to completely prevent any capture of Screenshots. It disables the collection of screenshots during the test runs when disableGifEncoder is set to true.

Linked GitHub issue ID:

Pull Request Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Code compiles correctly with all tests are passed.
  • I've read the contributing guide and followed the recommended practices.
  • Wikis or README have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

If this introduces a breaking change for Hydra Lab users, please describe the impact and migration path.

  • Yes
  • No

How you tested it

Please make sure the change is tested, you can test it by adding UTs, do local test and share the screenshots, etc.

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Technical design
  • Build related changes
  • Refactoring (no functional changes, no api changes)
  • Code style update (formatting, renaming) or Documentation content changes
  • Other (please describe):

Feature UI screenshots or Technical design diagrams

If this is a relatively large or complex change, kick it off by drawing the tech design with PlantUML and explaining why you chose the solution you did and what alternatives you considered, etc...

@ASPS002 ASPS002 changed the title top calls to addGifFrameAsyncDelay to prevent collection of screenshots Stop calls to addGifFrameAsyncDelay to prevent collection of screenshots Mar 25, 2025
@ASPS002
Copy link
Collaborator Author

ASPS002 commented Mar 25, 2025

/azp run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@ASPS002
Copy link
Collaborator Author

ASPS002 commented Mar 25, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ASPS002 ASPS002 merged commit 7021679 into main Mar 26, 2025
7 checks passed
@ASPS002 ASPS002 deleted the user/ujsrivastava/stop_taking_screenshots branch March 26, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants