Skip to content

Conversation

desertstsung
Copy link

I've got the similar problem like #6839, while compling my C code. According to the issue, I found out that Ten0/lightgbm-rs@243322e is a good solution, but not so robust, so I made this fix.

@desertstsung
Copy link
Author

@desertstsung please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@desertstsung desertstsung changed the title Bug-fix of include c_api.h in C code [C-API] Bug-fix of include c_api.h in C code Jul 22, 2025
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your interest in LightGBM.

@Ten0 @borchero could you help review this?

@jameslamb jameslamb changed the title [C-API] Bug-fix of include c_api.h in C code [C-API] Avoid C++ includes from arrow.h when including c_api.h Jul 23, 2025
@desertstsung desertstsung requested a review from jameslamb July 24, 2025 02:21
@desertstsung
Copy link
Author

Sorry for clicking Re-request review by accident.

@jameslamb
Copy link
Collaborator

/AzurePipelines run

@StrikerRUS
Copy link
Collaborator

/AzurePipelines run

@StrikerRUS
Copy link
Collaborator

/AzurePipelines run

@StrikerRUS
Copy link
Collaborator

/AzurePipelines run

Copy link
Collaborator

@borchero borchero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly don't know if this is the most ergonomic way to do this since I have too little experience with C(++) codebases 😅 as long as it works, I don't oppose it though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants