-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[C-API] Avoid C++ includes from arrow.h when including c_api.h #6973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for clicking |
/AzurePipelines run |
/AzurePipelines run |
/AzurePipelines run |
/AzurePipelines run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly don't know if this is the most ergonomic way to do this since I have too little experience with C(++) codebases 😅 as long as it works, I don't oppose it though
I've got the similar problem like #6839, while compling my C code. According to the issue, I found out that Ten0/lightgbm-rs@243322e is a good solution, but not so robust, so I made this fix.