-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[ci] use 'pre-commit' to run 'rstcheck' #6989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Could you please rename .ci/lint-python-bash.sh
to something like .ci/run-pre-commit-mypy.sh
because pre-commit becoming more than just python linting jobs?
Sure, good point! Just did that in 7635865 |
Ugh it looks like AGAIN someone has turned on this setting that requires a re-review after a push: ![]() I cannot merge this and see the following:
Previous times we've asked for this to be turned off and it seemed to have been for a bit:
It looks like I don't have permission to change the relevant ruleset: https://github.com/microsoft/LightGBM/settings/rules/5351760 I suspect it has to be a Microsoft employee. @letmaik can you please help us with this? Either turn this off or tell us "no, this is Microsoft policy, you just have to live with it"? As I said in #6872 (comment), this will really slow us down in this project :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapproving.
Thanks very much @StrikerRUS ! I hope someone from Microsoft will be able to finally and permanently resolve this branch protection issue for us, having to re-approve like this is even more demand on the already limited time we're giving to this project as volunteers 😫 |
Contributes to #6949 and #6901, by moving some logic out of
test.sh
rstcheck
intopre-commit
doxygen
in the docs-build conda environment so we don't need to manually install it in scriptsNotes for Reviewers
How I tested this
Added a directive like this to a file in
docs/
:.. garbage::
Then ran
pre-commit
Saw it catch that