Draft: [python-package] Sample from Sequence objects in batches, rather than row-by-row #7007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmusolino
requested review from
StrikerRUS,
borchero,
guolinke,
jameslamb,
jmoralez and
shiyu1994
as code owners
nmusolino
changed the title
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the Python package's
Datasetclass is constructed with a list of user-suppliedSequenceobjects, theDatasetsamples rows at random in a row-by-row manner. (The number of samples is controlled by thebin_construct_sample_cntparameter.)With this MR, the
Datasetclass will sample rows in batched fashion, by batching the randomly-generated row indices according to theSequenceobjects' length and batch size. In cases where all rows are being sampled, theSequenceobjects are indexed with slices.The goal is to allow user-defined
Sequenceclasses to provide data more efficiently or with better overall performance.See #7006 .